-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHP 8.2] Fixed some deprecation warnings #3155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Adminhtml
Relates to Mage_Adminhtml
Component: Eav
Relates to Mage_Eav
Component: Rule
Relates to Mage_Rule
Component: SalesRule
Relates to Mage_SalesRule
Component: Widget
Relates to Mage_Widget
Template : admin
Relates to admin template
labels
Apr 9, 2023
kiatng
reviewed
Apr 10, 2023
but in this case if value is 0 then if would be treated as false and would be wrong no? Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
github-actions
bot
added
the
Component: ConfigurableSwatches
Relates to Mage_ConfigurableSwatches
label
Apr 10, 2023
github-actions
bot
added
Component: Sales
Relates to Mage_Sales
and removed
Component: SalesRule
Relates to Mage_SalesRule
labels
Apr 10, 2023
kiatng
reviewed
Apr 11, 2023
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
fballiano
commented
Apr 11, 2023
kiatng
approved these changes
Apr 11, 2023
ADDISON74
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge it and I will make a list with the warnings left behind we still get in the log files.
kiatng
added a commit
to kiatng/magento-lts
that referenced
this pull request
Oct 11, 2023
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
Flyingmana
pushed a commit
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Adminhtml
Relates to Mage_Adminhtml
Component: ConfigurableSwatches
Relates to Mage_ConfigurableSwatches
Component: Eav
Relates to Mage_Eav
Component: Rule
Relates to Mage_Rule
Component: Sales
Relates to Mage_Sales
Component: Widget
Relates to Mage_Widget
Template : admin
Relates to admin template
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3152 @ADDISON74 found out some PHP 8.2 deprecation warnings, this PR should fix them.
Note: at the moment it still doesn't fix the problems with Mage_Paypal_Model_Config that apparently were introduced with #2759
Related Pull Requests
Fixed Issues