[PHP 8.2] Fixed deprecated dynamic property creation #3094
Conversation
github-actions
bot
added
Component: Catalog
| /** | ||
| * @var string | ||
| */ | ||
| private $_controller; | ||
|
|
||
| public function __construct() | ||
| { | ||
| $this->_blockGroup = 'currencysymbol_system'; | ||
| $this->_controller = 'adminhtml_system_currencysymbol'; | ||
| parent::__construct(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Deleted this since I couldn't find any usages for those variables.
| @@ -158,8 +156,6 @@ public function getProductEntityTypeId() | |||
| */ | |||
| protected function _joinFields() | |||
| { | |||
| $this->_totals = new Varien_Object(); | |||
There was a problem hiding this comment.
No usages found for this variable.
|
Strangely, I don't have any deprecated notice for that with PHP 8.2... on my Sentry instance. |
|
@luigifab I too didn't discover these through the logs, I only found them by looking for classes with |
fballiano
changed the title
|
merged and 20ed |
Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
|
Yes I tried to navigate to products page, categories page, made some orders... no notice for these properties. |
|
I found out that some of the modified classes are not even being used at all! |
Description (*)
This PR will fix some PHP 8.2 deprecations related to dynamic property creation, I found these by searching for doc blocks containing
@property, so it's possible that there's more.Contribution checklist (*)