Prevented Configurable Swatches assets from loading while unneeded #2999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: ConfigurableSwatches
elidrissidev
changed the title
app/code/core/Mage/ConfigurableSwatches/Block/Catalog/Media/Js/List.php
Outdated
Show resolved
Hide resolved
app/code/core/Mage/ConfigurableSwatches/Block/Catalog/Media/Js/List.php
Outdated
Show resolved
Hide resolved
…/List.php Co-authored-by: Mohamed ELIDRISSI <67818913+elidrissidev@users.noreply.github.com>
fballiano
reviewed
Jan 28, 2023
app/code/core/Mage/ConfigurableSwatches/Block/Catalog/Media/Js/List.php
Outdated
Show resolved
Hide resolved
fballiano
reviewed
Jan 29, 2023
app/code/core/Mage/ConfigurableSwatches/Block/Catalog/Media/Js/List.php
Outdated
Show resolved
Hide resolved
fballiano
previously approved these changes
Jan 29, 2023
|
This needs testing with layered navigation to make sure the removed js files are not used there. |
|
tested on category page with layered navigation and didn't see any problem |
kiatng
reviewed
Mar 20, 2023
app/code/core/Mage/ConfigurableSwatches/Block/Catalog/Media/Js/List.php
Outdated
Show resolved
Hide resolved
app/code/core/Mage/ConfigurableSwatches/Helper/Mediafallback.php
Outdated
Show resolved
Hide resolved
…/List.php Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
fballiano
approved these changes
Mar 20, 2023
empiricompany
approved these changes
Mar 30, 2023
ADDISON74
approved these changes
Mar 30, 2023
fballiano
changed the title
fballiano
added a commit
that referenced
this pull request
Mar 30, 2023
…2999) Co-authored-by: Mohamed ELIDRISSI <67818913+elidrissidev@users.noreply.github.com> Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com> Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
|
merged and 20ed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2998