Backported #1600: removed M1 legacy themes

[fballiano]

In the effort to reduce the differences between v19 and v20 and cleaup our codebase as much as possible, this PR backports #1600, the removal of the old and unmaintained app/design/frontend/default.

It was already done in v20 but with this PR we port it to v19.

Not to create problems to users who may use those themes, I created a backward compatibility module here: https://github.com/OpenMage/module-m1-default-themes which can be installed via composer (the README was updated with this information).

Related PR: #1600

[fballiano]

@sreichel @Flyingmana could you create the packagist entry for https://github.com/OpenMage/module-m1-default-themes? I think I can't do it. Thanks!

[addison74]

A small observation related to the name of the repository. m1 is not found in the other recently created ones. Maybe you should establish a rule about this. module-mage-poll, module-mage-tag, module-mage-pagecache, module-mage-backup are fine in my opinion.

[fballiano]

it is true, I used that naming because it's not really a module (since it's a group of themes) and I didn't want to name it "default themes" because it could be misleading, since these are the old "m1 default themes", I know it kinda sucks but I think it's the most understandable for this specific content. 🥺

[sreichel]

openmage/frontend-legacy-themes?

[sreichel]

Can this wait a bit? (#2863 (comment))

[fballiano]

for sure. I don't care about those mega old themes so I wouldn't fix them but we don't need to remove them urgently :-)

[sreichel]

Same for Mage_PageCache or Mage_Backup ...

Instead of removing "Components" from here and put them into a new repo, we can follow another approach ...

• split code into openmage-modules
• have all code in main-repo

See: https://github.com/symplify/monorepo-builder

[fballiano]

mmmm I continue thinking that this abandoned and unused code should leave this repo

[fballiano]

dunno why the "check modified files" fails but composer lock is ok

fab@MBP-Fab ~/P/openmage (backport_1600)> /usr/local/opt/php@7.3/bin/php /usr/local/bin/composer validate --strict
you may want to add the packages.firegento.com repository to composer.
add it with: composer.phar config -g repositories.firegento composer https://packages.firegento.com
you may want to add the packages.firegento.com repository to composer.
add it with: composer.phar config -g repositories.firegento composer https://packages.firegento.com
./composer.json is valid

[fballiano]

@elidrissidev @kiatng @addison74 guys can we move this one forward or should I close it?

[addison74]

Please keep it open for a while. I need to revise all those files to avoid any mistakes.

[fballiano]

thanks guys, merged and ported to 20.0