Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use getStoreConfigFlag() instead of (bool)getStoreConfig() #2747

Merged
merged 2 commits into from
Nov 20, 2022
Merged

Use getStoreConfigFlag() instead of (bool)getStoreConfig() #2747

merged 2 commits into from
Nov 20, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Nov 19, 2022 •
edited
Loading

Description (*)

Changes (bool)Mage::getStoreConfig() to Mage::getStoreConfigFlag().

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@sreichel
Use getStoreConfigFlag()
3967f72
@sreichel
Merge branch '1.9.4.x' into config-flag
1d50ce3 
# Conflicts:
#	app/code/core/Mage/Customer/Helper/Address.php
#	app/code/core/Mage/Rss/Block/List.php
@github-actions github-actions bot added Component: Admin Relates to Mage_Admin Component: Api PageRelates to Mage_Api Component: Catalog Relates to Mage_Catalog Component: Checkout Relates to Mage_Checkout Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Customer Relates to Mage_Customer Component: Directory Relates to Mage_Directory Component: PageCache Relates to Mage_PageCache Component: Rss Relates to Mage_Rss Component: Shipping Relates to Mage_Shipping labels Nov 19, 2022
fballiano
fballiano approved these changes Nov 20, 2022
View reviewed changes
Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

@fballiano fballiano merged commit 2da23d5 into OpenMage:1.9.4.x Nov 20, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 2da23d5. ± Comparison against base commit 2afbba9.

@sreichel sreichel deleted the config-flag branch November 20, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@elidrissidev elidrissidev elidrissidev approved these changes

Assignees
No one assigned
Labels
Cleanup Component: Admin Relates to Mage_Admin Component: Api PageRelates to Mage_Api Component: Catalog Relates to Mage_Catalog Component: Checkout Relates to Mage_Checkout Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Customer Relates to Mage_Customer Component: Directory Relates to Mage_Directory Component: PageCache Relates to Mage_PageCache Component: Rss Relates to Mage_Rss Component: Shipping Relates to Mage_Shipping
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @fballiano @elidrissidev