Hide and show RSS links #2741
Closed
Hide and show RSS links #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Adminhtml
sreichel
reviewed
Nov 18, 2022
sreichel
reviewed
Nov 20, 2022
4 tasks
sreichel
requested changes
Jan 3, 2023
There was a problem hiding this comment.
Seems you use wrong config pathes for admin grids.
Should be admin_catalog instead of catalog. See #2760 (comment)
|
Closed for #2760. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix some bugs with RSS links in Sales / Orders, Catalog / Products and Catalog / Reviews.
For example, when a RSS feed is disabled, it's not necessary to display the link.
Manual testing scenario
You need at least, two store views. Set the following configuration for one of them (not for the default store):
Go to Catalog / Reviews (same for Sales / Orders and Catalog / Products):
The RSS link must be displayed only for the store where the link is enabled, and the link must use the current selected store.
I hope it's good, at the beginning I started to only add
Mage::helper('catalog')->isModuleEnabled('Mage_Rss')andMage::getStoreConfigFlag('rss/xyz/xyz').Edit: I forgot to commit CSV update.
Contribution checklist