Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPStan: regenerated baseline for v20 branch #2690

Merged
merged 2 commits into from
Nov 7, 2022
Merged

PHPStan: regenerated baseline for v20 branch #2690

merged 2 commits into from
Nov 7, 2022

Conversation

fballiano
Copy link
Contributor

Since a while PHPStan fails on v20 branch, it was suggested by @sreichel (hope I remember correctly) to regenerate the baseline only for this branch, which this task does.

I used this command to do it:
/usr/local/opt/php@7.3/bin/php vendor/bin/phpstan analyse -c .github/phpstan.neon --generate-baseline .github/phpstan-baseline.neon --memory-limit=4G

@elidrissidev
Copy link
Member

I just noticed now that I forgot to include in #2641 phpstan configuration files for the phpstan workflow, cause it didn't run for this PR 🤦‍♂️

@fballiano
Copy link
Contributor Author

auch, github doesn't run phpstan on this specific PR...

anyway if I run:

fab@MBP-Fab ~/P/openmage (baseline)> /usr/local/opt/php@7.3/bin/php vendor/bin/phpstan  analyse -c .github/phpstan.neon --memory-limit=4G
 4072/4072 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


                                                                                                                        
 [OK] No errors                                                                                                         

@fballiano
Copy link
Contributor Author

I just noticed now that I forgot to include in #2641 phpstan configuration files for the phpstan workflow, cause it didn't run for this PR 🤦‍♂️

I guess we need to have it in another PR on the v19 branch

@fballiano
Copy link
Contributor Author

I just noticed now that I forgot to include in #2641 phpstan configuration files for the phpstan workflow, cause it didn't run for this PR 🤦‍♂️

I did this #2691

@fballiano fballiano merged commit 82e5168 into OpenMage:20.0 Nov 7, 2022
@fballiano fballiano deleted the baseline branch November 7, 2022 17:48
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  7 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 82e5168. ± Comparison against base commit 2b37965.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants