Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run workflows when relevant files change #2641

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Only run workflows when relevant files change #2641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/phpstan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ on:
# Run on all pushes and on all pull requests.
# Prevent the build from running when there are only irrelevant changes.
push:
paths-ignore:
- '**.md'
paths:
- '**.php'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we run phpstan also when we change phtml files?

Copy link
Member Author

@elidrissidev elidrissidev Oct 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From its configuration files I can only see app/code/* and lib/* directories included. Maybe someone else can confirm that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, app/design is not included.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we run phpstan also when we change phtml files?

No. W/o proper docblocks phpstan can't even resolve $this for block classes.

pull_request:
paths-ignore:
- '**.md'
paths:
- '**.php'
# Allow manually triggering the workflow.
workflow_dispatch:

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/phpunit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ on:
# Run on all pushes and on all pull requests.
# Prevent the build from running when there are only irrelevant changes.
push:
paths-ignore:
- '**.md'
paths:
- '**.php'
pull_request:
paths-ignore:
- '**.md'
paths:
- '**.php'
# Allow manually triggering the workflow.
workflow_dispatch:

Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/syntax-php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@ on:
# Run on all pushes and on all pull requests.
# Prevent the build from running when there are only irrelevant changes.
push:
paths-ignore:
- '**.md'
paths:
- '**.php'
- '**.phtml'
pull_request:
paths-ignore:
- '**.md'
paths:
- '**.php'
- '**.phtml'
# Allow manually triggering the workflow.
workflow_dispatch:

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/syntax-xml.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ on:
# Run on all pushes and on all pull requests.
# Prevent the build from running when there are only irrelevant changes.
push:
paths-ignore:
- '**.md'
paths:
- '**.xml'
pull_request:
paths-ignore:
- '**.md'
paths:
- '**.xml'
# Allow manually triggering the workflow.
workflow_dispatch:

Expand Down