Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP 8.1] Fix passing null to preg_split limit param #2616

Merged
merged 1 commit into from
Sep 24, 2022
Merged

[PHP 8.1] Fix passing null to preg_split limit param #2616

merged 1 commit into from
Sep 24, 2022

Conversation

elidrissidev
Copy link
Member

@elidrissidev elidrissidev commented Sep 23, 2022 •
edited by sreichel
Loading

Description (*)

This PR fixes the deprecation error in PHP 8.1 when passing null to preg_split's limit parameter, it should default to -1 if not being used.

Related Pull Requests

This PR was extracted from #2586 for ease of review and merging.

Manual testing scenarios (*)

  1. You should no longer see any deprecation errors related to preg_split usages.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@elidrissidev elidrissidev added the PHP 8 Related to PHP8 label Sep 23, 2022
@github-actions github-actions bot added Component: Core Relates to Mage_Core Component: Cron Relates to Mage_Cron Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Rule Relates to Mage_Rule labels Sep 23, 2022
fballiano
fballiano approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already tested in a previous pr

@sreichel sreichel merged commit bab41d1 into OpenMage:1.9.4.x Sep 24, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit bab41d1. ± Comparison against base commit 47c8177.

@elidrissidev elidrissidev deleted the fix/php8.1-preg_split branch September 24, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@sreichel sreichel sreichel approved these changes

Assignees
No one assigned
Labels
Component: Core Relates to Mage_Core Component: Cron Relates to Mage_Cron Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Rule Relates to Mage_Rule PHP 8 Related to PHP8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elidrissidev @fballiano @sreichel