Better admin/config validation for allowed currencies

[sreichel]

Description (*)

• fixes an error that allows to save no allowed currencies set.
• added some depends nodes to config fields

Manual testing scenarios (*)

1. go to admin, system, config, currencies
2. unselect all allowed currencies
3. try to save

Fatal error:  Uncaught TypeError: in_array(): Argument #2 ($haystack) must be of type array, string given in /var/www/html/app/code/core/Mage/Adminhtml/Model/System/Config/Backend/Currency/Default.php:44
Stack trace:
#0 /var/www/html/app/code/core/Mage/Adminhtml/Model/System/Config/Backend/Currency/Default.php(44): in_array('EUR', '')
#1 /var/www/html/app/code/core/Mage/Core/Model/Abstract.php(334): Mage_Adminhtml_Model_System_Config_Backend_Currency_Default->_afterSave()

Fatal error:  Uncaught Exception: User Error: Some transactions have not been committed or rolled back  in /var/www/html/lib/Varien/Db/Adapter/Pdo/Mysql.php on line 4063 in /var/www/html/app/code/core/Mage/Core/functions.php:194

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)

[ADDISON74]

I confirm this bug, here is what appears in the browser window:

I checked locally the PR and this appears in browser window when I want to save the list and there is no currency selected:

IMO the changes look fine. I didn't stop to analyze in detail what those additional dependencies bring, quite a lot in number.

[sreichel]

@ADDISON74 "depends" tag is to hide some options if "enabled" is set to "no".

Check Fixer.iO section before and after.

Edit: flushed cache?

[github-actions]

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit bbe1184. ± Comparison against base commit 71a2751.