Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgraded composer dependencies to also fit php7.3 #2576

Merged
merged 5 commits into from
Sep 21, 2022
Merged

Downgraded composer dependencies to also fit php7.3 #2576

merged 5 commits into from
Sep 21, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Sep 8, 2022

Description (*)

Current composer.lock file was made for "half-supported" php8.1 and some dependencies rely on php8.1.

This PR changes all requirements to work with php7.3+ (and 8.1).

  • no need to run composer update when not on 8.1
  • gitpod example should work (not tested)
  • (keep composer.lock?)

composer install should work for every php-version.

(also updated phpstan/ecg-standard)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the composer Relates to composer.json label Sep 8, 2022
@sreichel sreichel changed the title Downgraded composer requirements to fit php7.3 Downgraded composer dependencies to fit php7.3 Sep 8, 2022
@sreichel sreichel changed the title Downgraded composer dependencies to fit php7.3 Downgraded composer dependencies to also fit php7.3 Sep 8, 2022
fballiano
fballiano previously approved these changes Sep 8, 2022
@fballiano
Copy link
Contributor

so now we've to use php7.3 when we update composer.lock?

@sreichel
Copy link
Contributor Author

sreichel commented Sep 8, 2022

so now we've to use php7.3 when we update composer.lock?

Yes. (?)

@fballiano
Copy link
Contributor

guess I'll have to re-have that mega old version just for that

@sreichel
Copy link
Contributor Author

sreichel commented Sep 8, 2022

guess I'll have to re-have that mega old version just for that

https://github.com/OpenMage/magento-lts#development-environment-with-ddev 😎

@fballiano
Copy link
Contributor

That’s not the point 😉

@sreichel
Copy link
Contributor Author

sreichel commented Sep 12, 2022

so now we've to use php7.3 when we update composer.lock?

No. Tested ... if you want to update composer dependencies try this ...

composer config platform.php 7.3
composer update
composer config platform --unset

@sreichel sreichel merged commit 27447f9 into OpenMage:1.9.4.x Sep 21, 2022
@sreichel sreichel deleted the downgrade-composer-libs branch September 21, 2022 20:46
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 27447f9. ± Comparison against base commit d433ae9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
composer Relates to composer.json
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants