phpstan: fixed "Access to an undefined property"

[sreichel]

Description (*)

Set undefined properties. I hope its correct to make "new" properties public.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[fballiano]

why not protected?

[elidrissidev]

They should probably be protected by default unless there is a usage outside the class.

[sreichel]

They should probably be protected by default unless there is a usage outside the class.

Yes, BUT ... they were public all the time and someone could have used them outside the class.

I can change it, because they should have not been used outside. Let me know.

[fballiano]

right, but php 8.2 deprecates public properties so...
https://php.watch/versions/8.2/dynamic-properties-deprecated
what's the right choice here?

[sreichel]

Public is still okay, but not dynamically set.

[github-actions]

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit d033c75. ± Comparison against base commit a24224d.