Remove legacy media uploader / editor remnants

[justinbeaty]

Description (*)

Removed a few javascript files related to lib/flex which was previously removed in #2271

However I also removed some blocks, controllers, and phtml files which seem like they are not used anywhere.

Maybe the only removal I'm not sure about is app/code/core/Mage/Adminhtml/Block/Media/Uploader.php because maybe some extension adds this block to a layout.

The two controllers seem useless.

https://store.example.com/index.php/admin/media_uploader
https://store.example.com/index.php/admin/media_editor

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

1. Perhaps a good idea to pull both this and Flow.js updates #2433 into your local tree
2. Try to upload media files in various places in the backend. I'm not sure of the complete list of places you can normally upload files, I know of uploading images or downloadable files in manage products... Where else can we upload?

Questions or comments

This is a draft because I think it needs to be tested by others before merging. Edit: Marked ready for review, although let's please still test it. It seems fine for me, but maybe someone else knows if those controllers I deleted were ever used. I honestly don't think they were anymore and are just cruft.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[lgtm-com]

This pull request fixes 7 alerts when merging a4820fe into 71998f5 - view on LGTM.com

fixed alerts:

• 3 for Missing variable declaration
• 3 for Incomplete string escaping or encoding
• 1 for Call to eval-like DOM function

[fballiano]

I was about to write you about FABridge :-D

[lgtm-com]

This pull request fixes 16 alerts when merging 9bfadb7 into 71998f5 - view on LGTM.com

fixed alerts:

• 8 for Missing variable declaration
• 3 for Comparison between inconvertible types
• 3 for Incomplete string escaping or encoding
• 1 for Unreachable statement
• 1 for Call to eval-like DOM function

[fballiano]

tested and found no problems, there's nothing about those 2 controllers anywhere in the code and the uploads still work

[lgtm-com]

This pull request fixes 16 alerts when merging 13bd371 into 5aece6d - view on LGTM.com

fixed alerts:

• 8 for Missing variable declaration
• 3 for Comparison between inconvertible types
• 3 for Incomplete string escaping or encoding
• 1 for Unreachable statement
• 1 for Call to eval-like DOM function

[luigifab]

I like this idea!

[justinbeaty]

Fixed conflicts