Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in cron scripts #2380

Merged
merged 5 commits into from
Sep 29, 2022
Merged

Improvements in cron scripts #2380

merged 5 commits into from
Sep 29, 2022

Conversation

fballiano
Copy link
Contributor

@fballiano fballiano commented Aug 8, 2022

cron.php scripts hides some errors redirecting output to /dev/null, it should be avoided since it caused issue #1675

In the meanwhile I added a check for the availability of the ps, sed and expr commands.

Fixed Issues

  1. Fixes Cron fails silently in environment with jailed shells #1675

@fballiano fballiano changed the title Improvements in cron running scripts Improvements in cron scripts Aug 8, 2022
ADDISON74
ADDISON74 previously approved these changes Aug 12, 2022
cron.php Outdated Show resolved Hide resolved
Sdfendor
Sdfendor previously approved these changes Aug 12, 2022
ADDISON74
ADDISON74 previously approved these changes Aug 12, 2022
cron.php Show resolved Hide resolved
cron.sh Outdated Show resolved Hide resolved
@sreichel sreichel removed their request for review September 23, 2022 22:12
@elidrissidev
Copy link
Member

@fballiano Any update about this?

@fballiano
Copy link
Contributor Author

sorry, I'll work on it asap

@fballiano fballiano dismissed stale reviews from ADDISON74 and Sdfendor via 4ea4912 September 28, 2022 17:07
Copy link
Member

@elidrissidev elidrissidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good

@fballiano fballiano merged commit 1373cb5 into OpenMage:1.9.4.x Sep 29, 2022
@fballiano fballiano deleted the issue_1675 branch September 29, 2022 06:54
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 1373cb5. ± Comparison against base commit c5c34fc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cron fails silently in environment with jailed shells
5 participants