Skip to content

Conversation

addison74
Copy link
Contributor

This first PR removes colons that are after the words From, To and In in Backend grid heads to achieve a little more width space and a better visual improvement.

In the next PR (it is ready but I am still testing) in the case of columns with date range the calendar button will be moved to the right.

Both PR's will solve the issues reported here #2198 and #2239.

Here is before:

before

Here is after:

after

When both PR's will be merged this is the final result:

after

Remove colons after From and To
Remove colons after From and To
Remove colons after From, To and In
Remove colons after From and Two
@addison74 addison74 linked an issue Jun 30, 2022 that may be closed by this pull request
@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Jun 30, 2022
@fballiano fballiano merged commit af8d068 into OpenMage:1.9.4.x Jun 30, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit af8d068. ± Comparison against base commit acb4505.

@addison74 addison74 deleted the ADDISON74-backend-grid-filter branch June 30, 2022 16:18
elidrissidev pushed a commit to elidrissidev/magento-lts that referenced this pull request Jul 9, 2022
elidrissidev pushed a commit to elidrissidev/magento-lts that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dates columns in Backend grids need visual improvement
3 participants