Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README.md contributors badge #1627

Merged
merged 2 commits into from
Jul 31, 2021
Merged

Conversation

mehdichaouch
Copy link
Contributor

Fix README.md contributors badge, causing the display of badge url code.

@colinmollenhour
Copy link
Member

I don't know much about this badge but I think the "101" part of the url is basically meant to be dynamically replaced by the All Contributors bot so this PR would break that. Granted, it is already broken! 😄 #1614

@mehdichaouch
Copy link
Contributor Author

mehdichaouch commented May 20, 2021

I don't know much about this badge but I think the "101" part of the url is basically meant to be dynamically replaced by the All Contributors bot so this PR would break that. Granted, it is already broken! 😄 #1614

Oh I understand, by fixing this I maybe broke the bot in charge of changing this dynamically.

@mehdichaouch
Copy link
Contributor Author

DON'T MERGE MY PULL REQUEST.

I read more about all-contributors-bot config, I think installation have to be checked and workflow to add contributor was not respected.

@Flyingmana
Copy link
Contributor

Flyingmana commented May 21, 2021

@mehdichaouch yes there is somewhere a related ticket. We did not "install" the all contributors bot, because it needs write access to the repository, which could be used in a possible supply-chain-attack.

Means, it needs to be manually run and used to create PullRequests

@mehdichaouch
Copy link
Contributor Author

mehdichaouch commented May 21, 2021

@Flyingmana thank you for your answer.

So what about the badge, do you have a solution do fix it?
Should I close my PR or not?

@colinmollenhour
Copy link
Member

Means, it needs to be manually run and used to create PullRequests

Is this something you could document somewhere very briefly like an internal wiki?

@fballiano
Copy link
Contributor

what are we doing with this? it's really ugly to have a broken README

@Flyingmana
Copy link
Contributor

Iam ok with merging it for now to fix the obvious error and take care of the automatism separately

Flyingmana
Flyingmana previously approved these changes Jun 25, 2021
@Flyingmana Flyingmana merged commit be65e79 into OpenMage:1.9.4.x Jul 31, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  ±0  4 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit be65e79. ± Comparison against base commit 9b04ad2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants