-
-
Notifications
You must be signed in to change notification settings - Fork 447
(BC) Remove js index file #1622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would love to see it in 1.9.4.x as well, removing it will allow to have whole js/ static with legit "php_flag engine 0" in js/.htaccess and default nginx config serving js/ as static files. |
@jouriy this PR is a BC for people that use this old functionality, so I changed to 20.0. |
@luigifab, great, I can keep it on my own, so no problem |
fballiano
approved these changes
Jun 7, 2022
addison74
approved these changes
Jun 7, 2022
tmewes
approved these changes
Jun 7, 2022
akunzai
added a commit
to akunzai/MageBridgeCore
that referenced
this pull request
Nov 25, 2023
akunzai
added a commit
to akunzai/MageBridgeCore
that referenced
this pull request
Nov 25, 2023
akunzai
added a commit
to akunzai/MageBridgeCore
that referenced
this pull request
Nov 26, 2023
akunzai
added a commit
to akunzai/MageBridgeCore
that referenced
this pull request
Nov 26, 2023
akunzai
added a commit
to akunzai/MageBridgeCore
that referenced
this pull request
Nov 26, 2023
akunzai
added a commit
to akunzai/MageBridgeCore
that referenced
this pull request
Nov 26, 2023
akunzai
added a commit
to akunzai/MageBridgeCore
that referenced
this pull request
Nov 26, 2023
akunzai
added a commit
to akunzai/MageBridgeCore
that referenced
this pull request
Nov 26, 2023
akunzai
added a commit
to akunzai/MageBridgeCore
that referenced
this pull request
Nov 26, 2023
akunzai
added a commit
to akunzai/MageBridgeCore
that referenced
this pull request
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR require #1618 because it remove the last usage of:
I think it's so outdated.
Contribution checklist