don't redirect to "downloader" (which doesn't exists) #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downloader was removed with #952 so it's useless to redirect to the downloader subdir. Also, I think the purpose of checkin if the MAGENTO_ROOT . '/app/Mage.php' is useless, one file check for every request while magento wouldn't work at all if it didn't exist, I think that check has to be removed, there's no point in executing it.
kiatng
approved these changes
Apr 6, 2021
Flyingmana
suggested changes
Apr 6, 2021
kiatng
approved these changes
Apr 9, 2021
|
I think this should really be merged, the downloader doesn't exist since some time and this check is just a waste of CPU clocks, let's close this and move on to other stuff no? ;-) I know I'm a pain in the *** but I keep checking for my issues/PR and so I don't use the time to do other stuff for the project. |
|
what should we do about this? |
colinmollenhour
approved these changes
Apr 22, 2021
|
@Flyingmana @sreichel @kiatng I think this one could be easily merged, otherwise close it and let's forget it (but I can't see why) |
|
I agree that this should be merged to v20. |
kkrieger85
approved these changes
May 12, 2021
Flyingmana
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the main index.php there's a check for the app/Mage.php (which is 99.9% useless) and a redirect to the "magento downloader".
Downloader was removed with #952 so it's useless to redirect to the downloader subdir. Also, I think the purpose of checkin if the MAGENTO_ROOT . '/app/Mage.php' is useless, one file check for every request while magento wouldn't work at all if it didn't exist, I think that check has to be removed, there's no point in executing it.