Add checkout agreement position, closes #1288 #1480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Adminhtml
kiatng
approved these changes
Mar 3, 2021
colinmollenhour
approved these changes
Mar 4, 2021
kkrieger85
approved these changes
Mar 12, 2021
|
This commit was not merged in OpenMage 20.0.8 even it has a milestone for this version. Are there any other commits which were not merged in OpenMage? Some missed from human error? |
This was referenced Apr 21, 2021
Flyingmana
added a commit
that referenced
this pull request
May 16, 2021
* Update agreements.phtml By PR #1480 which is merged in OM the content field is no longer required. If it is not filled in an empty container will be visible in frontend. This PR comes to solve this issue. * Uppercase format in Sales menu - Terms and conditions This commit will change in Backend -> Sales menu a link name from "Terms and conditions" to "Terms and Conditions". It is not necessary to add the text in /app/locale/en_US/Mage_Checkout.csv because it already exists. I chose to keep the old version too. * Wrong attributes order in comparison window This PR fixes the issue #1289. * Update Collection.php Co-authored-by: Daniel Fahlke <flyingmana@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
See https://magento.stackexchange.com/questions/174332/magento-1-terms-and-conditions-sort-order-if-more-than-one
It's already included in firegento/magesetup and will be updated there too.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)