Skip to content

Replace alias methods #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2021
Merged

Replace alias methods #1394

merged 1 commit into from
Mar 11, 2021

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jan 13, 2021 •
edited
Loading

Description (*)

  • join vs implode
  • is_integer vs is_int
  • ...

Related Pull Requests

#986

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@sreichel
Replace alias methods
f61608d 
- join vs implode
- is_integer vs is_int
- ...
@sreichel sreichel added the Cleanup: Code style Related to simple CS fixes. label Jan 13, 2021
@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Admin Relates to Mage_Admin Component: Backup Relates to Mage_Backup Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogRule Relates to Mage_CatalogRule Component: CatalogIndex Relates to Mage_CatalogIndex Component: CatalogSearch Relates to Mage_CatalogSearch Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: ImportExport Relates to Mage_ImportExport Component: Log Relates to Mage_Log Component: Payment Relates to Mage_Payment Component: ProductAlert Relates to Mage_ProductAlert Component: Reports Relates to Mage_Reports Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Sitemap Relates to Mage_Sitemap Component: Tag Relates to Mage_Tag Component: Usa Relates to Mage_Usa Component: Wishlist Relates to Mage_Wishlist labels Jan 13, 2021
@sreichel sreichel requested a review from Flyingmana February 25, 2021 20:01
@Flyingmana Flyingmana removed their request for review February 25, 2021 20:39
@sreichel sreichel added this to the Release 19.4.12 / 20.0.8 milestone Mar 11, 2021
@sreichel sreichel merged commit 7526749 into OpenMage:1.9.4.x Mar 11, 2021
@sreichel sreichel deleted the cs/alias-methods branch March 11, 2021 23:30
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7526749. ± Comparison against base commit 59983f9.

@addison74
Copy link
Contributor

Why this commit was closed? It should be merged in OpenMage.

@colinmollenhour
Copy link
Member

This one did get merged...

@addison74
Copy link
Contributor

You are right. Sorry for the post.

@Sdfendor Sdfendor mentioned this pull request Aug 9, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@tmotyl tmotyl tmotyl approved these changes

@kkrieger85 kkrieger85 Awaiting requested review from kkrieger85

Assignees
No one assigned
Labels
Cleanup: Code style Related to simple CS fixes. Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: Backup Relates to Mage_Backup Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogIndex Relates to Mage_CatalogIndex Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogRule Relates to Mage_CatalogRule Component: CatalogSearch Relates to Mage_CatalogSearch Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: ImportExport Relates to Mage_ImportExport Component: Log Relates to Mage_Log Component: Payment Relates to Mage_Payment Component: ProductAlert Relates to Mage_ProductAlert Component: Reports Relates to Mage_Reports Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Sitemap Relates to Mage_Sitemap Component: Tag Relates to Mage_Tag Component: Usa Relates to Mage_Usa Component: Wishlist Relates to Mage_Wishlist
Projects
None yet
Milestone
Release 19.4.12 / 20.0.8
Development

Successfully merging this pull request may close these issues.
4 participants
@sreichel @addison74 @colinmollenhour @tmotyl