Removed unused variable

[midlan]

Description (*)

Just removed unused variable.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)

[Flyingmana]

could have unintended side effects on internal initialization and also about when the event "adminhtml_init_system_config" is called

[midlan]

@Flyingmana you are right about the event adminhtml_init_system_config, we should check if there is observers for it

About the init, seems safe to me. It is simple lazy-loading pattern, I don't see how it may behave differently when lazy-loaded from different model.

[luigifab]

PayPal use the adminhtml_init_system_config event with paypal/observer::loadCountryDependentSolutionsConfig.
But I didn't see any emails added with Mage_Paypal.

The only configuration about email that I found is: email_confirmation, used in API request.

The base branch was changed.

[Flyingmana]

I moved it to the 20.0 branch, because even if it looks ok, I want to not risk issues, and its not a bugfix, so not necessarily needed in the 1.9.4.x branch.

[github-actions]

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  ±0  6 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5cb3187. ± Comparison against base commit 10da7af.

[empiricompany]

removing this line i can't load email template from admin

PHP Fatal error:  Uncaught Error: Call to a member function xpath() on null in /htdocs/app/code/core/Mage/Adminhtml/Model/Config.php:208

Stack trace:
#0 /htdocs/app/code/core/Mage/Adminhtml/Block/System/Email/Template/Edit.php(386): Mage_Adminhtml_Model_Config->getSystemConfigNodeLabel('sales_email')

#1 /htdocs/app/code/core/Mage/Adminhtml/Block/System/Email/Template/Edit.php(317): Mage_Adminhtml_Block_System_Email_Template_Edit->_getSystemConfigPathsParts(Array)

#2 /htdocs/app/code/core/Mage/Adminhtml/controllers/System/Email/TemplateController.php(227): Mage_Adminhtml_Block_System_Email_Template_Edit->getUsedDefaultForPaths(false)

#3 /htdocs/app/code/core/Mage/Core/Controller/Varien/Action.php(437): Mage_Adminhtml_System_Email_TemplateController->defaultTemplateAction()

#4 /htdocs/app/code/core/Mage/Core/Controller/Varien/Router/Standard.php(262):  in /htdocs/app/code/core/Mage/Adminhtml/Model/Config.php on line 208

[kiatng]

I can replicate the error reported by @empiricompany in backend > System > Transactional Emails > Add New Template > select any template in the Template dropdown and then click button Load Template. No template is loaded, PHP logs the error

PHP Fatal error: Uncaught Error: Call to a member function xpath() on null in /../app/code/core/Mage/Adminhtml/Model/Config.php:208

After restoring this line

Mage::getSingleton('adminhtml/config')->getSections();

The template loaded successfully. It looks like we need to revert this merge.