Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused fetchAll in addRatingInfo() #1274

Merged
merged 5 commits into from
Dec 12, 2020

Conversation

Sekiphp
Copy link
Contributor

@Sekiphp Sekiphp commented Oct 21, 2020

Description (*)

In method addRatingInfo is fetching of results but output of the function is not used anywhere. This optimalization should make faster product page.

Manual testing scenarios (*)

Compare catched all SQL queries on product page before and after this change.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added the Component: Rating Relates to Mage_Rating label Oct 21, 2020
@tmotyl tmotyl added the performance Performance related label Oct 21, 2020
@Flyingmana Flyingmana merged commit 597d02d into OpenMage:1.9.4.x Dec 12, 2020
@sreichel sreichel added this to the Release 19.4.9 / 20.0.5 milestone Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Rating Relates to Mage_Rating hacktoberfest-accepted performance Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants