Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mage_Eav - Fix PHP 7.4 deprecation: array/string curly braces access #1182

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Mage_Eav - Fix PHP 7.4 deprecation: array/string curly braces access #1182

merged 1 commit into from
Sep 10, 2020

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Sep 3, 2020 •
edited
Loading

Description (*)

Fixes php-74 array/string curly braces access deprection warning.

Related Pull Requests

  1. fix php7.4 syntax deprecated warnings #859

Manual testing scenarios (*)

  1. see https://github.com/OpenMage/magento-lts/pull/1181/checks?check_run_id=1067053140

Questions or comments

Should we change php-74 syntax check to non-experimental (and include lib/Zend)?

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@sreichel sreichel added the PHP 7.x Related to PHP 7.x label Sep 3, 2020
@github-actions github-actions bot added the Component: Eav Relates to Mage_Eav label Sep 3, 2020
@sreichel sreichel mentioned this pull request Sep 3, 2020
Merged
3 tasks
@Flyingmana Flyingmana merged commit 6ae5839 into OpenMage:1.9.4.x Sep 10, 2020
@sreichel sreichel deleted the hotfix/php-74/mage-eav branch September 10, 2020 20:12
@Flyingmana Flyingmana changed the title Fix PHP 7.4 deprecation: array/string curly braces access Mage_Eav - Fix PHP 7.4 deprecation: array/string curly braces access Sep 14, 2020
@sreichel sreichel added this to the Release 19.4.7 / 20.0.3 milestone Sep 15, 2020
aldrahastur pushed a commit to aldrahastur/magento-lts that referenced this pull request Sep 22, 2020
@sreichel @aldrahastur
Fix PHP 7.4 deprecation: array/string curly braces access (OpenMage#1182
13153b6 
)

Co-authored-by: Sven Reichel <sven.reichel@sandstein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@Flyingmana Flyingmana Flyingmana approved these changes

@joshua-bn joshua-bn joshua-bn approved these changes

Assignees
No one assigned
Labels
Component: Eav Relates to Mage_Eav PHP 7.x Related to PHP 7.x
Projects
None yet
Milestone
Release 19.4.7 / 20.0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@sreichel @colinmollenhour @Flyingmana @joshua-bn