Ensure correctly sorted block children after unset some of them #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tting blocks... this is causing wrong sort order
colinmollenhour
approved these changes
Jul 24, 2020
speedupmate
pushed a commit
to speedupmate/magento-lts
that referenced
this pull request
Sep 16, 2020
…tting blocks... this is causing wrong sort order (OpenMage#1108) Co-authored-by: Hannes Drittler <h.drittler@lemundo.de>
aldrahastur
pushed a commit
to aldrahastur/magento-lts
that referenced
this pull request
Sep 22, 2020
…tting blocks... this is causing wrong sort order (OpenMage#1108) Co-authored-by: Hannes Drittler <h.drittler@lemundo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset indices of block children array since they have gaps after unsetting blocks... this is causing wrong sort order
Description (*)
To "unset" blocks in layout XML is causing missing numbers in the array index of block children. This leads to wrong positions of child blocks (despite their attribute values of after/before in block definition) since the sort algorithm can not handle missing numbers in array index.
Manual testing scenarios (*)
Contribution checklist (*)