Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve problem with Magento Connect Tls #108

Closed
wants to merge 1 commit into from

Conversation

Flyingmana
Copy link
Contributor

Copy link
Contributor

@LeeSaferite LeeSaferite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CURL_SSLVERSION_TLSv1 constant was only added in PHP 5.5 and will cause issues for prior versions. I suggest you change it to the numeric value 1 unless we are changing the min PHP version for LTS.

Copy link
Member

@colinmollenhour colinmollenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While PHP 5.4 and 5.5 are officially EOL, I think that since some popular Linux distros are still supporting PHP 5.4 (Debian Jessie, CentOS 7, Ubuntu 12.04 LTS) that 5.4 should probably remain supported for now. Should be easy to add fix: defined('CURL_SSLVERSION_TLSv1') ? CURL_SSLVERSION_TLSv1 : 'TLSv1'

@Flyingmana
Copy link
Contributor Author

actually CURL_SSLVERSION_TLSv1 resolves to just 1, which is now used by magento in the newest version.

@Flyingmana Flyingmana closed this Jan 9, 2017
@colinmollenhour colinmollenhour deleted the Flyingmana-patch-1 branch August 29, 2017 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants