Fix bug related to filter in Admin UI for Role Users #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiatng
approved these changes
Jun 24, 2020
|
Looks good! I don't see any problem with the solution. I tested it and it works. |
|
I can confirm this bug. The type casting was implemented with PATCH SUPEE-11155 CE 1.9.4.0 v3-2019-06-18-08-34-01. Maybe you make a type cast to array? |
theroch
suggested changes
Jun 25, 2020
sreichel
added
the
code change requested
kkrieger85
approved these changes
Jul 23, 2020
sreichel
removed
the
code change requested
Flyingmana
changed the title
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 20, 2020
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unable to filter Role Users in Permission->Roles->Role Users or go to next Page or change the number of rows displayed per page.
This bug is introduced in pull request d644768
Mage_Adminhtml_Block_Permissions_Role_Grid_User->_getUsers() is returning an int instead of an array on line 160.