ownerTree.container is undefined for product categories

[luigifab]

With OpenMage 20.1.0-rc4, when I go to Products > Any Product > Categories, at store view level, I get the following error: ownerTree.container is undefined

magento-lts/js/extjs/ext-tree-checkbox.js

Lines 65 to 69 in 1431628

	render : function(bulkRender){
	var n = this.node;
	var targetNode = n.parentNode ?
	n.parentNode.ui.getContainer() : n.ownerTree.container.dom; /* in later svn builds this changes to n.ownerTree.innerCt.dom */
	if(!this.rendered){

My 10 seconds solution is to replace, line 67/68 by: var targetNode = n.parentNode ? n.parentNode.ui.getContainer() : (n.ownerTree.container ? n.ownerTree.container.dom : n.ownerTree.innerCt.dom);

But I'm not sure why, and if it's only me.

[fballiano]

true, it's not only you

[elidrissidev]

Could possibly be related to the update made in #2473

[justinbeaty]

I will take a look at this today. It’s seems I did miss this instance of extjs being used in the backend.

[justinbeaty]

It would seem that just the following is enough to fix this:

var targetNode = n.parentNode ?
    n.parentNode.ui.getContainer() : n.ownerTree.innerCt.dom;

Because of the comment on that line:

in later svn builds this changes to n.ownerTree.innerCt.dom

Recall that ext-tree-checkbox.js was not a part of ExtJS, but a plugin for ExtJS written by somebody many years ago. It seems they were aware that the newer version of ExtJS had a breaking change, and documented it in that comment. But since Magento never updated ExtJS, they never updated ext-tree-checkbox.

I am not sure that we need the nested ternary code in @luigifab's original comment, unless we have some case where someone is still running the older ExtJS but with the newer ext-tree-checkbox (which I'm not sure how that would happen.) It also doesn't hurt though, I guess.