v19.4.20

[fballiano]

Overview

This is mainly a bugfix release with a couple of optimizations.
Most importantly we've fixed bugs regarding:

• fixer.io currency exchange rate provider
• CSS merge
• indexes

Upgrading is highly suggested, but always backup and test before doing it.

What's Changed

• Set php version for phpstan by @sreichel in Set php version for phpstan #2692
• Do not autoload captcha class when disabled by @luigifab in Do not autoload captcha class when disabled #2681
• Do not crash when shipment does not exist by @luigifab in Do not crash when shipment does not exist #2683
• Trimmed files by @luigifab in Trim files #2698
• Reduce again getId calls by @luigifab in Reduce again getId calls #2699
• Add link to the product page and float default qty for bundle items by @luigifab in Add link to the product page and float default qty for bundle items #2701
• Remove obsolete ACL resources from DB by @sreichel in Remove obsolete ACL resources from DB #2706
• Allow labeler workflow to fail by @sreichel in Allow labeler workflow to fail #2710
• Bugfix to make exchange rate data with fixer.io work again by @dbachmann in Bugfix to make exchange rate data with fixer.io work again #2694
• Fixes typo in join alias in indexer by @rubanooo in Fixes typo in join alias in indexer #2711
• Removed support for eAccelerator Cache Backend by @fballiano in Removed support for eAccelerator Cache Backend #2712
• Set the right menu for reviews by @luigifab in Set the right menu for reviews #2680
• Version bump for next release by @fballiano in Version bump for next release #2714
• Added confirmation before deleting website/store/storeview by @fballiano in Added confirmation before deleting website/store/storeview #2717
• Fixed typo in copyright docblock by @fballiano in Fixed typo in copyright docblock #2740
• Add method code in payment method list by @luigifab in Add method code in payment method list #2735
• Set width:auto for td.massaction by @luigifab in Set width:auto for td.massaction #2718
• Fix data.title replace when it's null/undefined by @luigifab in Fix data.title replace when it's null/undefined #2719
• Add PHPCodeSniffer to workflow by @sreichel in Add PHPCodeSniffer to workflow #2708
• Use getStoreConfigFlag() instead of (bool)getStoreConfig() by @sreichel in Use getStoreConfigFlag() instead of (bool)getStoreConfig() #2747
• Replaces full class name with self by @sreichel in Replaces full class name with self #2749
• Updated phpdocs: return $this by @sreichel in Updated phpdocs: return $this #2751
• Backport: add logging to lockfile related Exceptions #1149 by @sreichel in Backport: #1149 #2745
• Fixed incorrect docblock for setLastRealOrderId() and getLastRealOrde… by @kiatng in Fixed incorrect docblock for setLastRealOrderId() and getLastRealOrde… #2752
• Fix: merge CSS files /w missing file by @sreichel in Fix: merge CSS files /w missing file #2754
• Backport: Order add comment functionality in REST API #2315 by @sreichel in Backport: #2315 #2746
• Fixed setting of source_model when adding new attribute and for multiselect. by @kiatng in Fixed setting of source_model when adding new attribute and for multiselect. #1293
• Remove declared properties accessed by magic getter in Paypal Config by @elidrissidev in Remove declared properties accessed by magic getter in Paypal Config #2759
• Fix Order comment REST endpoint route param by @elidrissidev in Fix Order comment REST endpoint route param #2750
• Moved DDEV docs by @sreichel in Moved DDEV docs #2764
• Add php-cs-fixer & PHPCompatibility check to workflow by @sreichel in Add php-cs-fixer & PHPCompatibility check to workflow #2744
• PhpStan L5 fixes for Mage/Admin by @sreichel in PhpStan L5 fixes for Mage/Admin #2761

Full Changelog: v19.4.19...v19.4.20

---

This discussion was created from the release v19.4.20.

[empiricompany]

in this release there is a typo in lib/Magento/Db/Adapter/Pdo/Mysql.php on line 135
rray_key_exists

    public function quote($value, $type = null)
    {
        $this->_connect();

        if ($type !== null
            && rray_key_exists($type = strtoupper($type), $this->_numericDataTypes)
            && $this->_numericDataTypes[$type] == Zend_Db::FLOAT_TYPE
        ) {
            $value = $this->_convertFloat($value);
            $quoteValue = sprintf('%F', $value);
            return $quoteValue;
        } elseif (is_float($value)) {
            return $this->_quote($value);
        }

        return parent::quote($value, $type);
    }

[fballiano]

it was already solved today (by @sreichel), one of the few directories that wasn't under phpstan check until now

[sreichel]

@fballiano i know ive fixed it in one of my PRs, but its not merged. Should i open a PR for this?

edit #2788

fixed in #2780

[empiricompany]

it was already solved today (by @sreichel), one of the few directories that wasn't under phpstan check until now

Can we update this release please? Are there any other typos that need to be fixed in this release?

[fballiano]

please review #2766 and #2165, we can't release without those two.