-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial enhancements #442
Conversation
Any idea why the notebook test is failing? Is it because of the additional packages? |
not sure actually. I was trying to debug this locally, but the GH workflow is not entirely trivial and relies on GH magic, not locally executable bash scripts or alike. |
and the "new" packages are not actually 'extra'. They are part of some docs, which the respective developers seem to have used locally, but did not add to the |
It's either a corrupt package or an incomplete download. I would restart the build. Where do we use ipython syntax? |
IIRC there was a rebuild after my last commit and the error did not chance.
here: docs/source/user_guide/interfacing_ml_libraries.rst:.. code-block:: ipython3 |
Yep. I think the action is wrong. It tries to check all changed files. Deleted files are changed files as well but of course cannot be tested anymore. I think the previous error with the download was a hiccup. |
Ah hmm that is quite some overhead to install ipython just for colorizing two lines.. |
ok, this seems to have done it. The list of changed files now excludes deleted files. |
This PR enhances the pyOpenMS docs