fix a couple bugs with supersonic panel case #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the src_indices issue with run_parallel.py is due to this issue I just opened: OpenMDAO/OpenMDAO#3513 I'm guessing fixing that will require no other changes to the supersonic panel codes (it still works with older OpenMDAO versions anyway, up until get_outputs_dir which I think is newer than the old version I tested with). |
|
The src_indices issue is now fixed per OpenMDAO/OpenMDAO#3514, so this should be ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple bugs were recently introduced to the supersonic panel codes: a broken geometry connection in run_parallel.py (due to the geometry coordinate input lacking a tag), and a missing "if name == "main":". The src_indices in run_parallel.py also aren't working now.