I682 add CI matrix entry for testing without pyoptsparse #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so restored the full test matrix
…so restored the full test matrix
…b.com/hschilling/dymos into I682-add-dymos-ci-without-pyoptsparse
Kenneth-T-Moore
approved these changes
Dec 13, 2021
robfalck
requested changes
Dec 13, 2021
swryan
reviewed
Dec 13, 2021
| @@ -5,7 +5,7 @@ name: Dymos Tests | |||
| on: | |||
| # Trigger on push or pull request events for the master branch | |||
| push: | |||
| branches: [ master ] | |||
| branches: [ master, I682-add-dymos-ci-without-pyoptsparse ] | |||
| # MBI: 1 | ||
| # OPENMDAO: 'latest' | ||
| # OPTIONAL: '[all]' | ||
| # DOCS: 1 |
… require_pyoptsparse decorators but not specific to SNOPT. SNOPT should not be needed now
robfalck
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added CI matrix entry for the case where pyoptsparse is not installed.
Also, moved 3
require_pyoptsparsedecorators fromsetUpmethod to test class they were contained in. Having them onsetUpwas causing problems because theuse_tempdirdecorator, which was also on these classes, was not being completely executed when pyoptsparse was not installed. Therequire_pyoptsparsedecorator short-circuited the process and the test never was put back into the home directory. This causes failures in parts of the CI that followed. Specifically, the coveralls part of the CI expected to find the .coverage file in the home directory.Related Issues
Backwards incompatibilities
None
New Dependencies
None