Disabled check_partials of Dymos core components by default. #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ials behavior of dymos components
…ials unless DYMOS_CHECK_PARTIALS environment variable is set to a truthy value
…_partials_env_variable
…iable in the middle of tests
…nscription classes (continuity comp) that was already handled in the PseudospectralBase class
DKilkenny
approved these changes
Nov 30, 2021
| @@ -211,8 +218,6 @@ def test_polynomial_control_group_scalar_radau(self): | |||
| promotes_inputs=['*'], | |||
| promotes_outputs=['*']) | |||
|
|
|||
| # p.model.connect('dt_dstau', 'control_interp_comp.dt_dstau') | |||
There was a problem hiding this comment.
There's 3 other occurrences of this line in the file. Delete all of them?
Kenneth-T-Moore
approved these changes
Nov 30, 2021
…_partials_env_variable
DKilkenny
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Dymos option 'include_check_partials' now gets its default value from the environment variable
DYMOS_CHECK_PARTIALS, if defined. Otherwise it defaults to False.Added tests that test partials for a few of the larger Dymos examples, with three transcriptions that support derivatives, to verify that no Dymos-related core components show up in partials checks when they shoudln't.
Related Issues
Backwards incompatibilities
Default value for
dymos.options['include_check_partials']is nowFalse.New Dependencies
None