Phases now have simulate_options #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… changing multiple options quickly. Default atol and rtol for solve_ivp are now the scipy.integrate.solve_ivp results! (backwards incompatible) Changed the order of some arguments in some API methods (phase.get_simulation_phase), but users are unlikely to encounter this.
Kenneth-T-Moore
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Phases now have
simulate_options, which currently consists of themethod,atol,rtol,first_step, andmax_stepoptions used by scipy.integrate.solve_ivp.The user may set these options through the options dictionary interface:
or through the new
set_simulate_optionsmethod that allows setting multiple values at once:This allows phases to each have their own appropriate solve_ivp settings when using simulate from the trajectory level, or when using the
dymos.run_probleminterface withsimulate=True.Once the new documentation is up, this capability will be added to the new documentation.
Related Issues
Status
Backwards incompatibilities
get_simulation_phase. Most users should not see any difference since these methods are internal (and should probably be underscored in the future to convey that fact).New Dependencies
None