Fixed an issue where default values in add_control or set_control_options were no longer being respected. #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_input_defaults call was no longer meaningful. These default values had to be applied at add_input instead. Also, the test to see if default values were sticking was no longer valid because it depended on a problem creation function that was overriding the values after setup anyway. These issues have been fixed.
…lt_control_val_fix
Kenneth-T-Moore
approved these changes
Apr 4, 2025
…es in the phase. Fixed a numpy deprecation regarding scalar reshapes in reshape_val. No longer add state and control continuity constraints in ODEEvaluationGroup for the purpose of being able to compute their derivatives when running in simulation and derivatives are not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The default control values were set using a call to set_input_defaults, which went away because the ControlInterpComp is no longer housed in a ControlGroup. Values are now applied at add_input, and the test to make sure these default values stick has been fixed.
Related Issues
add_controlorset_control_optionsis not applied. #1166Backwards incompatibilities
None
New Dependencies
None