Use SDL relative mouse mode for right click dragging where available #3022
Conversation
| _cursorDragStart = cursor; | ||
| Ui::hideCursor(); | ||
|
|
||
| auto result = SDL_SetRelativeMouseMode(SDL_TRUE); |
There was a problem hiding this comment.
should this be a game option the user can enable?
There was a problem hiding this comment.
I don't think so. SDL_SetRelativeMouseMode is, as far as I can tell, a better implementation of a feature OpenLoco had implemented (hiding the cursor and detecting relative mouse motion, without your mouse movements being limited by the size of your screen/window).
It should be look and feel exactly the same to users, except it will now work properly even in edge cases such as starting the right click drag from a position near the edge of your monitor.
The only reason I left the old system in as a fallback is because the documentation says "If relative mode is not supported, this returns -1", and I was being perhaps overly cautious?
2 participants
The benefit of this is that the mouse is not able to get stopped by the edges of the monitor when using relative mode, thus slightly improving the user experience: Now right mouse dragging will work as expected even when you start from the edge of the screen.