Skip to content

fix(offline_download): prevent infinite retry on status update failure - #2294

Merged
xrgzs merged 1 commit into
OpenListTeam:mainfrom
sdvcrx:main
Apr 3, 2026
Merged

fix(offline_download): prevent infinite retry on status update failure#2294
xrgzs merged 1 commit into
OpenListTeam:mainfrom
sdvcrx:main

Conversation

@sdvcrx

@sdvcrx sdvcrx commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Description / 描述

代码原意应该是失败5次后就退出,但因为代码顺序问题,导致 t.tool.Status(t) 失败超过5次后不会自动退出,出现无限次重试。

Motivation and Context / 背景

错误日志:

ERRO[2026-03-05 17:03:05] failed to get status of pyGVF4hJtjt7kHyQtl878, retried 1848 times
ERRO[2026-03-05 17:03:08] failed to get status of 51FeEG1KM_tYLLond7A2u, retried 5940 times
ERRO[2026-03-05 17:03:08] failed to get status of _n5JQoHVyoUV2cXhJNOZd, retried 1850 times
ERRO[2026-03-05 17:03:08] failed to get status of UttGaFfIZrAjqabQ1PKsR, retried 1849 times
ERRO[2026-03-05 17:03:08] failed to get status of pyGVF4hJtjt7kHyQtl878, retried 1849 times

How Has This Been Tested? / 测试

Checklist / 检查清单

  • I have read the CONTRIBUTING document.
    我已阅读 CONTRIBUTING 文档。
  • I have formatted my code with go fmt or prettier.
    我已使用 go fmtprettier 格式化提交的代码。
  • I have added appropriate labels to this PR (or mentioned needed labels in the description if lacking permissions).
    我已为此 PR 添加了适当的标签(如无权限或需要的标签不存在,请在描述中说明,管理员将后续处理)。
  • I have requested review from relevant code authors using the "Request review" feature when applicable.
    我已在适当情况下使用"Request review"功能请求相关代码作者进行审查。
  • I have updated the repository accordingly (If it’s needed).
    我已相应更新了相关仓库(若适用)。

@Suyunmeng
Suyunmeng force-pushed the main branch 4 times, most recently from a31fd53 to 7bea29c Compare April 2, 2026 17:27

@xrgzs xrgzs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前被刷过,确实存在这个问题,LGTM

@xrgzs
xrgzs merged commit 12c9bdb into OpenListTeam:main Apr 3, 2026
10 checks passed
EnterTang pushed a commit to EnterTang/OpenList that referenced this pull request Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants