Skip to content

Conversation

@FloEdelmann
Copy link
Member

  • Add fixture 'fun-generation/picowash-40-pixel-quad-led'

Fixture warnings / errors

  • fun-generation/picowash-40-pixel-quad-led
    • ❌ File does not match schema. [ { keyword: 'required',
      dataPath: '.matrix',
      schemaPath: '#/properties/matrix/oneOf/0/required',
      params: { missingProperty: '.pixelCount' },
      message: 'should have required property '.pixelCount'' },
      { keyword: 'required',
      dataPath: '.matrix',
      schemaPath: '#/properties/matrix/oneOf/1/required',
      params: { missingProperty: '.pixelKeys' },
      message: 'should have required property '.pixelKeys'' },
      { keyword: 'oneOf',
      dataPath: '.matrix',
      schemaPath: '#/properties/matrix/oneOf',
      params: { passingSchemas: null },
      message: 'should match exactly one schema in oneOf' },
      [length]: 3 ]
    • ⚠️ Please check if manufacturer is correct.
    • ⚠️ Please check 16bit channel 'Pan (fine)': The corresponding coarse channel could not be detected.
    • ⚠️ Please check 16bit channel 'Tilt (fine)': The corresponding coarse channel could not be detected.
    • ⚠️ Please add 25 Channel mode's Head initial structure #1 to the fixture's matrix. The included channels were LED 1 Red, LED 1 Green, LED 1 Blue, LED 1 White.
    • ⚠️ Please add 25 Channel mode's Head Initial styling #2 to the fixture's matrix. The included channels were LED 2 Red, LED 2 Green, LED 2 Blue, LED 2 White.
    • ⚠️ Please add 25 Channel mode's Head Add meaningful tests #3 to the fixture's matrix. The included channels were LED 3 Red, LED 3 Green, LED 3 Blue, LED 3 White.
    • ⚠️ Please add 25 Channel mode's Head make UI responsive #4 to the fixture's matrix. The included channels were LED 4 Red, LED 4 Green, LED 4 Blue, LED 4 White.

User comment

As delivered with QLC 4.11.2
Author info from their changelog

Thank you Harm Aldick!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels May 11, 2019
@FloEdelmann FloEdelmann had a problem deploying to open-fixture-library-pr-898 May 11, 2019 00:02 Failure
Copy link
Member

@fxedel fxedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FloEdelmann Please review as well

@FloEdelmann
Copy link
Member Author

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ fun-generation / picowash-40-pixel-quad-led: d-light / attributes-correctness
  • heavy_check_mark: fun-generation/picowash-40-pixel-quad-led-3ch.xml
  • heavy_check_mark: fun-generation/picowash-40-pixel-quad-led-8ch.xml
  • heavy_check_mark: fun-generation/picowash-40-pixel-quad-led-13ch.xml
  • heavy_check_mark: fun-generation/picowash-40-pixel-quad-led-25ch.xml
✔️ fun-generation / picowash-40-pixel-quad-led: millumin / json-schema-conformity
  • heavy_check_mark: fun-generation/picowash-40-pixel-quad-led.json
✔️ fun-generation / picowash-40-pixel-quad-led: qlcplus_4.11.2 / xsd-schema-conformity
  • heavy_check_mark: Fun-Generation-PicoWash-40-Pixel-Quad-LED.qxf
✔️ fun-generation / picowash-40-pixel-quad-led: qlcplus_4.12.1 / fixture-tool-validation
  • heavy_check_mark: Fun-Generation-PicoWash-40-Pixel-Quad-LED.qxf
✔️ fun-generation / picowash-40-pixel-quad-led: qlcplus_4.12.1 / xsd-schema-conformity
  • heavy_check_mark: Fun-Generation-PicoWash-40-Pixel-Quad-LED.qxf

Copy link
Member Author

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ LGTM

@FloEdelmann FloEdelmann merged commit 6624b94 into master May 13, 2019
@FloEdelmann FloEdelmann deleted the branch2019-05-11T00-01-58 branch May 13, 2019 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants