-
Notifications
You must be signed in to change notification settings - Fork 82
Add fixture 'fun-generation/picowash-40-pixel-quad-led' #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fxedel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FloEdelmann Please review as well
Export files validity(Output of test script Test the exported files of selected fixtures against the plugins' export tests. ✔️ fun-generation / picowash-40-pixel-quad-led: d-light / attributes-correctness
✔️ fun-generation / picowash-40-pixel-quad-led: millumin / json-schema-conformity
✔️ fun-generation / picowash-40-pixel-quad-led: qlcplus_4.11.2 / xsd-schema-conformity
✔️ fun-generation / picowash-40-pixel-quad-led: qlcplus_4.12.1 / fixture-tool-validation
✔️ fun-generation / picowash-40-pixel-quad-led: qlcplus_4.12.1 / xsd-schema-conformity
|
Broken links(Output of test script There were 0 internal and 4 external links failing.
|
FloEdelmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ LGTM
Fixture warnings / errors
dataPath: '.matrix',
schemaPath: '#/properties/matrix/oneOf/0/required',
params: { missingProperty: '.pixelCount' },
message: 'should have required property '.pixelCount'' },
{ keyword: 'required',
dataPath: '.matrix',
schemaPath: '#/properties/matrix/oneOf/1/required',
params: { missingProperty: '.pixelKeys' },
message: 'should have required property '.pixelKeys'' },
{ keyword: 'oneOf',
dataPath: '.matrix',
schemaPath: '#/properties/matrix/oneOf',
params: { passingSchemas: null },
message: 'should match exactly one schema in oneOf' },
[length]: 3 ]
User comment
As delivered with QLC 4.11.2
Author info from their changelog
Thank you Harm Aldick!