Skip to content

Conversation

@FloEdelmann
Copy link
Member

  • Update manufacturers.json
  • Add fixture light4me/30-spot-ring

Fixture warnings / errors

  • light4me/30-spot-ring
    • ❌ File does not match schema: fixture/matrix/pixelCount/0 -Infinity must be >= 1
    • ❌ File does not match schema: fixture/matrix/pixelCount/1 -Infinity must be >= 1
    • ❌ File does not match schema: fixture/wheels/Color wheel/slots/14 (type: Unknown) value of tag "type" must be in oneOf
    • ❌ File does not match schema: fixture/wheels/Ring wheel/slots/0 (type: Unknown) value of tag "type" must be in oneOf
    • ❌ File does not match schema: fixture/wheels/Ring wheel/slots/8 (type: Unknown) value of tag "type" must be in oneOf
    • ❌ File does not match schema: fixture/templateChannels must NOT have fewer than 1 properties
    • ⚠️ Please check if manufacturer is correct and add manufacturer URL.
    • ⚠️ Please add 12-channel mode's Head initial structure #1 to the fixture's matrix. The included channels were Pan, Pan fine, Tilt, Tilt fine, Pan/Tilt speed.

Thank you @mlunax!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Oct 2, 2024
@github-actions
Copy link

github-actions bot commented Oct 2, 2024

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ light4me / 30-spot-ring: d-light / attributes-correctness
  • ✔️ light4me/30-spot-ring-12ch.xml
light4me / 30-spot-ring: dmxcontrol3 / channel-numbers
  • ❌ light4me-30-spot-ring-12ch.xmlChannel 6 "Gobo wheel" is missing capabilities. Used ranges: 0…63, 128…255
light4me / 30-spot-ring: dragonframe / json-schema-conformity
  • ❌ light4me/30-spot-ring.jsonfixture/matrix/pixelCount/0 null must be integer
  • ✔️ manufacturers.json
light4me / 30-spot-ring: millumin / json-schema-conformity
  • ❌ light4me/30-spot-ring.jsonfixture/matrix/pixelCount/0 null must be integer
light4me / 30-spot-ring: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/LIGHT4ME-30-Spot-Ring.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf: Invalid physical dimensions detected ./manufacturer/fixture.qxf: Invalid PAN degrees ./manufacturer/fixture.qxf: Invalid TILT degrees 1 definitions processed. 3 errors detected
light4me / 30-spot-ring: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/LIGHT4ME-30-Spot-Ring.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Layout', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.

@mlunax
Copy link

mlunax commented Oct 2, 2024

Close this, ignore pls
bad file, sorry

@FloEdelmann
Copy link
Member Author

Alright, thanks for the notice.

@FloEdelmann FloEdelmann closed this Oct 8, 2024
@FloEdelmann FloEdelmann deleted the branch2024-10-02T16-44-17 branch October 8, 2024 17:14
@FloEdelmann FloEdelmann added the invalid Issue or PR is not intending to improve OFL or misunderstands its concepts. label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid Issue or PR is not intending to improve OFL or misunderstands its concepts. new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants