Skip to content

Improve UI #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FloEdelmann merged 42 commits into from
Mar 7, 2017
Merged

Improve UI #32

FloEdelmann merged 42 commits into from
Mar 7, 2017

Conversation

@fxedel
Copy link
Member

@fxedel fxedel commented Mar 1, 2017

#18

@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-32 March 1, 2017 15:21 Inactive
@fxedel fxedel added the component-ui Affects the user interface on the open-fixture-library.org website. label Mar 1, 2017
@fxedel
Moved some directories
46fe156 
- public/ to static/
- stylesheets/ to views/stylesheets/
- views/partials/ to views/includes/
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-32 March 1, 2017 16:23 Inactive
@fxedel
Renamed 'partials' everywhere to 'includes'
4dafcdf 
Moved icons in static/ to static/icons
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-32 March 1, 2017 16:40 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-32 March 1, 2017 16:58 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-32 March 1, 2017 17:02 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-32 March 1, 2017 17:56 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-32 March 1, 2017 18:07 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-32 March 1, 2017 21:00 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-32 March 1, 2017 23:30 Inactive
@FloEdelmann
Copy link
Member

FloEdelmann commented Mar 2, 2017 •
edited
Loading

According to caniuse.com, all current browsers understand the .woff and/or .woff2 font format. I suggest we therefore ditch the .ttf and .eot versions to keep it simple and to save some space.

Regarding the manufacturers page: I guess we should make our life easy and just don't show the comment or website in the overview, but only on individual manufacturer pages. Then we can just reuse the cards from the categories.

@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-32 March 2, 2017 07:46 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-32 March 2, 2017 12:08 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-32 March 2, 2017 12:27 Inactive
FloEdelmann
FloEdelmann reviewed Mar 2, 2017
View reviewed changes
views/stylesheets/content.scss Outdated

&:hover,
&:focus {
&[href]:hover,
Copy link
Member

@FloEdelmann FloEdelmann Mar 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this to :link, please

Copy link
Member Author

@fxedel fxedel Mar 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We simply don't show manufacturers without fixtures anymore.

@fxedel
Only show manufacturers mentioned in register
2538077 
This avoids having <a> elements with no href attribute
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-32 March 4, 2017 22:37 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-32 March 5, 2017 17:08 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-32 March 5, 2017 17:24 Inactive
@fxedel
Copy link
Member Author

fxedel commented Mar 5, 2017 •
edited by FloEdelmann
Loading

  • Source link
  • More margin between categories
  • Put multi-byte channels and head in top card
  • Show channel key in monospace font if it differs from channel name
  • Hide undefined properties
  • Style capabilities (inclusive dropdown)
  • Channel type icons / color
  • SingleColor Generic should be discouraged

@fxedel
Copy link
Member Author

fxedel commented Mar 5, 2017

Use no break space ( ) between "Last modified:" / "Created:" / "Authors:" and their values.

@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-32 March 7, 2017 15:52 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-32 March 7, 2017 18:29 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-32 March 7, 2017 19:50 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-32 March 7, 2017 20:50 Inactive
@FloEdelmann FloEdelmann requested a deployment to open-fixture-library-pr-32 March 7, 2017 21:12 Pending
@FloEdelmann FloEdelmann changed the title WIP: Improve UI Improve UI Mar 7, 2017
@FloEdelmann FloEdelmann merged commit bd2abe7 into master Mar 7, 2017
@FloEdelmann FloEdelmann deleted the muilga branch March 7, 2017 21:41
@FloEdelmann FloEdelmann mentioned this pull request Sep 6, 2018
Merged
11 tasks
This was referenced Dec 6, 2025
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees

No one assigned

Labels

component-ui Affects the user interface on the open-fixture-library.org website.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fxedel @FloEdelmann