Add fixture shehds/mini-led-spot-beam-10w-light
#3140
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloEdelmann
added
new-fixture
Export files validity(Output of test script Test the exported files of selected fixtures against the plugins' export tests. ✔️ shehds / mini-led-spot-beam-10w-light: d-light / attributes-correctness
✔️ shehds / mini-led-spot-beam-10w-light: dmxcontrol3 / channel-numbers
✔️ shehds / mini-led-spot-beam-10w-light: dragonframe / json-schema-conformity
✔️ shehds / mini-led-spot-beam-10w-light: millumin / json-schema-conformity
✔️ shehds / mini-led-spot-beam-10w-light: qlcplus_4.12.2 / fixture-tool-validation
✔️ shehds / mini-led-spot-beam-10w-light: qlcplus_4.12.2 / xsd-schema-conformity
|
kengruven
reviewed
May 2, 2025
Contributor
kengruven
left a comment
kengruven
left a comment
There was a problem hiding this comment.
Looks good -- just a few minor suggestions.
Comment on lines
+38
to
+39
| "defaultValue": 0, | ||
| "precedence": "LTP", |
Contributor
There was a problem hiding this comment.
Suggested change
| "defaultValue": 0, | |
| "precedence": "LTP", |
Comment on lines
+48
to
+49
| "defaultValue": 0, | ||
| "precedence": "LTP", |
Contributor
There was a problem hiding this comment.
Suggested change
| "defaultValue": 0, | |
| "precedence": "LTP", |
Comment on lines
+57
to
+58
| "defaultValue": 0, | ||
| "precedence": "LTP", |
Contributor
There was a problem hiding this comment.
Suggested change
| "defaultValue": 0, | |
| "precedence": "LTP", |
| "Strobe": { | ||
| "defaultValue": 0, | ||
| "capability": { | ||
| "type": "StrobeSpeed", |
Contributor
There was a problem hiding this comment.
Suggested change
| "type": "StrobeSpeed", | |
| "type": "StrobeSpeed", | |
| "helpWanted": "At what values is the strobe disabled?", |
Comment on lines
+66
to
+67
| "defaultValue": 0, | ||
| "precedence": "LTP", |
Contributor
There was a problem hiding this comment.
Suggested change
| "defaultValue": 0, | |
| "precedence": "LTP", |
| }, | ||
| "modes": [ | ||
| { | ||
| "name": "11 Channel", |
Contributor
There was a problem hiding this comment.
Suggested change
| "name": "11 Channel", | |
| "name": "11 channel", |
| ] | ||
| }, | ||
| { | ||
| "name": "13 Channel", |
Contributor
There was a problem hiding this comment.
Suggested change
| "name": "13 Channel", | |
| "name": "13 channel", |
| "comment": "Mini 10W small moving head light.", | ||
| "links": { | ||
| "manual": [ | ||
| "https://www.shehds.com/u_file/1907/file/ea38ccee37.pdf" |
Contributor
There was a problem hiding this comment.
Suggested change
| "https://www.shehds.com/u_file/1907/file/ea38ccee37.pdf" | |
| "https://drive.google.com/file/d/1bkQN656McsI1W0tiUShOzcbm4Vlt9cvv/view" |
| "type": "LED RGBW" | ||
| }, | ||
| "lens": { | ||
| "degreesMinMax": [5, 15] |
Contributor
There was a problem hiding this comment.
Suggested change
| "degreesMinMax": [5, 15] | |
| "degreesMinMax": [4.5, 4.5] |
| ] | ||
| }, | ||
| "physical": { | ||
| "dimensions": [127, 135, 127], |
Contributor
There was a problem hiding this comment.
Suggested change
| "dimensions": [127, 135, 127], | |
| "dimensions": [145, 120, 260], |
The webpage and manual disagree. This is what the manual says. The webpage seems unreliable in other aspects (e.g., 7/15 DMX channels, when their own downloads have only 13ch modes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shehds/mini-led-spot-beam-10w-lightThank you @william-fireone!