Skip to content

Implement fixture feedback #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FloEdelmann merged 2 commits into from
Feb 5, 2023
Merged

Implement fixture feedback #3057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd53a87
Implement feedback for `shehds/led-flat-par-7x18w-rgbwa-uv-light`
FloEdelmann Feb 5, 2023
5e16fcd
Implement feedback for `fun-generation/picospot-45-led`
FloEdelmann Feb 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 91 additions & 12 deletions fixtures/fun-generation/picospot-45-led.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
"name": "PicoSpot 45 LED",
"categories": ["Moving Head", "Color Changer"],
"meta": {
"authors": ["Felix Edelmann"],
"authors": ["Felix Edelmann", "Peter Käning", "Flo Edelmann"],
"createDate": "2019-08-21",
"lastModifyDate": "2019-08-21"
"lastModifyDate": "2023-02-05"
},
"links": {
"manual": [
Expand Down Expand Up @@ -228,25 +228,104 @@
"Gobo Wheel": {
"capabilities": [
{
"dmxRange": [0, 124],
"dmxRange": [0, 15],
"type": "WheelSlot",
"slotNumberStart": 1,
"slotNumberEnd": 8,
"helpWanted": "At which DMX value can which gobo be selected? Are split positions between two gobos possible?"
"slotNumber": 1
},
{
"dmxRange": [16, 31],
"type": "WheelSlot",
"slotNumber": 2
},
{
"dmxRange": [32, 47],
"type": "WheelSlot",
"slotNumber": 3
},
{
"dmxRange": [48, 63],
"type": "WheelSlot",
"slotNumber": 4
},
{
"dmxRange": [64, 79],
"type": "WheelSlot",
"slotNumber": 5
},
{
"dmxRange": [80, 95],
"type": "WheelSlot",
"slotNumber": 6
},
{
"dmxRange": [96, 111],
"type": "WheelSlot",
"slotNumber": 7
},
{
"dmxRange": [112, 124],
"type": "WheelSlot",
"slotNumber": 8
},
{
"dmxRange": [125, 249],
"dmxRange": [125, 140],
"type": "WheelShake",
"slotNumberStart": 2,
"slotNumberEnd": 8,
"helpWanted": "At which DMX value can which gobo be selected? Are split positions between two gobos possible?"
"slotNumber": 8,
"shakeSpeedStart": "slow",
"shakeSpeedEnd": "fast"
},
{
"dmxRange": [141, 156],
"type": "WheelShake",
"slotNumber": 7,
"shakeSpeedStart": "slow",
"shakeSpeedEnd": "fast"
},
{
"dmxRange": [157, 172],
"type": "WheelShake",
"slotNumber": 6,
"shakeSpeedStart": "slow",
"shakeSpeedEnd": "fast"
},
{
"dmxRange": [173, 188],
"type": "WheelShake",
"slotNumber": 5,
"shakeSpeedStart": "slow",
"shakeSpeedEnd": "fast"
},
{
"dmxRange": [189, 204],
"type": "WheelShake",
"slotNumber": 4,
"shakeSpeedStart": "slow",
"shakeSpeedEnd": "fast"
},
{
"dmxRange": [205, 220],
"type": "WheelShake",
"slotNumber": 3,
"shakeSpeedStart": "slow",
"shakeSpeedEnd": "fast"
},
{
"dmxRange": [221, 236],
"type": "WheelShake",
"slotNumber": 2,
"shakeSpeedStart": "slow",
"shakeSpeedEnd": "fast"
},
{
"dmxRange": [237, 249],
"type": "WheelSlot",
"slotNumber": 1
},
{
"dmxRange": [250, 255],
"type": "WheelRotation",
"speedStart": "slow CW",
"speedEnd": "fast CW",
"helpWanted": "Is this really wheel rotation? The manual mentions 'Gobo wheel selection'."
"speedEnd": "fast CW"
}
]
},
Expand Down
125 changes: 104 additions & 21 deletions fixtures/shehds/led-flat-par-7x18w-rgbwa-uv-light.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
"categories": ["Color Changer"],
"comment": "There may be multiple variants of this fixture with similar profiles. See https://github.com/OpenLightingProject/open-fixture-library/pull/2204 for more information.",
"meta": {
"authors": ["jms27000", "René Bütikofer"],
"authors": ["jms27000", "René Bütikofer", "Flo Edelmann"],
"createDate": "2022-11-02",
"lastModifyDate": "2022-11-02",
"lastModifyDate": "2023-02-05",
"importPlugin": {
"plugin": "qlcplus_4.12.1",
"date": "2021-10-16",
Expand Down Expand Up @@ -82,55 +82,138 @@
},
"Strobe": {
"defaultValue": 0,
"capability": {
"type": "ShutterStrobe",
"shutterEffect": "Strobe",
"speedStart": "0Hz",
"speedEnd": "10Hz",
"helpWanted": "At which DMX values is the strobe effect disabled?"
}
"capabilities": [
{
"dmxRange": [0, 4],
"type": "ShutterStrobe",
"shutterEffect": "Open"
},
{
"dmxRange": [5, 255],
"type": "ShutterStrobe",
"shutterEffect": "Strobe",
"speedStart": "0Hz",
"speedEnd": "20Hz"
}
]
},
"Function": {
"defaultValue": 0,
"capabilities": [
{
"dmxRange": [0, 50],
"type": "NoFunction"
"type": "NoFunction",
"switchChannels": {
"Function Speed / Color Presets": "Color Presets"
}
},
{
"dmxRange": [51, 100],
"type": "Effect",
"effectName": "Auto Mode 1",
"helpWanted": "At which DMX value does the effect start?"
"effectName": "Static color",
"switchChannels": {
"Function Speed / Color Presets": "Color Presets"
}
},
{
"dmxRange": [101, 150],
"type": "Effect",
"effectName": "Auto Mode 2",
"helpWanted": "At which DMX value does the effect start?"
"effectPreset": "ColorJump",
"comment": "Random colors",
"switchChannels": {
"Function Speed / Color Presets": "Function Speed"
}
},
{
"dmxRange": [151, 200],
"type": "Effect",
"effectName": "Auto Mode 3",
"helpWanted": "At which DMX value does the effect start?"
"effectPreset": "ColorFade",
"comment": "Random colors",
"switchChannels": {
"Function Speed / Color Presets": "Function Speed"
}
},
{
"dmxRange": [201, 255],
"dmxRange": [201, 250],
"type": "Effect",
"effectPreset": "ColorFade",
"comment": "Random colors, fade to black",
"switchChannels": {
"Function Speed / Color Presets": "Function Speed"
}
},
{
"dmxRange": [251, 255],
"type": "Effect",
"soundControlled": true,
"effectName": "Sound Mode",
"helpWanted": "At which DMX value does the effect start?"
"comment": "Static color flashing on beat",
"switchChannels": {
"Function Speed / Color Presets": "Color Presets"
}
}
]
},
"Function Speed": {
"defaultValue": 0,
"capability": {
"type": "Speed",
"type": "EffectSpeed",
"speedStart": "slow",
"speedEnd": "fast"
}
},
"Color Presets": {
"defaultValue": 0,
"capabilities": [
{
"dmxRange": [0, 31],
"type": "ColorPreset",
"comment": "Red",
"colors": ["#ff0000"]
},
{
"dmxRange": [32, 63],
"type": "ColorPreset",
"comment": "Green",
"colors": ["#00ff00"]
},
{
"dmxRange": [64, 95],
"type": "ColorPreset",
"comment": "Blue",
"colors": ["#0000ff"]
},
{
"dmxRange": [96, 127],
"type": "ColorPreset",
"comment": "White",
"colors": ["#ffffff"]
},
{
"dmxRange": [128, 159],
"type": "ColorPreset",
"comment": "Amber",
"colors": ["#ffbf00"]
},
{
"dmxRange": [160, 191],
"type": "ColorPreset",
"comment": "UV",
"colors": ["#8800ff"]
},
{
"dmxRange": [192, 223],
"type": "ColorPreset",
"comment": "Cyan",
"colors": ["#00ffff"]
},
{
"dmxRange": [224, 255],
"type": "ColorPreset",
"comment": "Warm White",
"colors": ["#fff6da"]
}
]
}
},
"modes": [
Expand Down Expand Up @@ -158,7 +241,7 @@
"Amber",
"Violet",
"Function",
"Function Speed"
"Function Speed / Color Presets"
]
},
{
Expand All @@ -174,7 +257,7 @@
"Violet",
"Strobe",
"Function",
"Function Speed"
"Function Speed / Color Presets"
]
}
]
Expand Down