Mobile UI #27
Merged
Mobile UI #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fxedel
added
the
component-ui
Also fixed a lot of other things
FloEdelmann
requested changes
Mar 1, 2017
Member
FloEdelmann
left a comment
FloEdelmann
left a comment
There was a problem hiding this comment.
Also, we should hide the text in the logo and search button by giving the elements zero width and using padding-left instead.
public/style.css
Outdated
| } | ||
|
|
||
| header>nav { | ||
| header nav { |
| padding: var(--padding); | ||
| width: var(--icon-size); | ||
| height: var(--icon-size); | ||
| box-sizing: content-box; |
Member
There was a problem hiding this comment.
This is the default. Why add it?
Member
Author
There was a problem hiding this comment.
It isn't, as this is a button.
public/style.css
Outdated
| background: #5294e2; | ||
| header button:hover { | ||
| background-color: var(--blue-300); | ||
| border-color: transparent; |
Member
There was a problem hiding this comment.
Does the button visually "shrink" by that? If so, I'd rather use var(--blue-300) here, too.
| color: inherit; | ||
| header button:active { | ||
| background-color: var(--blue-700); | ||
| border-color: transparent; |
Member
Author
|
Fixed in last commit. |
FloEdelmann
approved these changes
Mar 1, 2017
Closed
11 tasks
This was referenced Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4.
@FloEdelmann Feel free to add points that make the website more responsive.