Skip to content

Conversation

@FloEdelmann
Copy link
Member

  • Update manufacturers.json
  • Add fixture 'betopper/lc001-h'

Thank you frumaki!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Jun 18, 2022
@github-actions
Copy link

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ betopper / lc001-h: d-light / attributes-correctness
  • ✔️ betopper/lc001-h-D.xml
  • ✔️ betopper/lc001-h-A.xml
✔️ betopper / lc001-h: dmxcontrol3 / channel-numbers
  • ✔️ betopper-lc001-h-D.xml
  • ✔️ betopper-lc001-h-A.xml
✔️ betopper / lc001-h: dragonframe / json-schema-conformity
  • ✔️ betopper/lc001-h.json
  • ✔️ manufacturers.json
✔️ betopper / lc001-h: millumin / json-schema-conformity
  • ✔️ betopper/lc001-h.json
✔️ betopper / lc001-h: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Betopper-LC001-H.qxf
betopper / lc001-h: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/Betopper-LC001-H.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': '0' is not a valid value of the atomic type '{http://www.qlcplus.org/FixtureDefinition}weightType'.

@luc122c luc122c marked this pull request as draft February 16, 2023 23:28
@FloEdelmann FloEdelmann changed the title Add fixture 'betopper/lc001-h' Add fixture betopper/lc001-h May 8, 2023
Copy link
Contributor

@kengruven kengruven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

"capability": {
"type": "StrobeSpeed",
"speedStart": "slow",
"speedEnd": "fast"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"speedEnd": "fast"
"speedEnd": "fast",
"helpWanted": "At what values is the strobe disabled?"

],
"productPage": [
"https://betopperdj.com/products/betopper-100w-cob-light-lc001-h"
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
]
],
"video": [
"https://www.youtube.com/watch?v=4ttjQEtGsag"
]

},
"links": {
"manual": [
"https://cdn.shopifycdn.net/s/files/1/0084/5230/9047/files/BETOPPER_Stage_Led_Light_COB_Par_Light_LC001-H_User_Manual.pdf?v=1630045858"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"https://cdn.shopifycdn.net/s/files/1/0084/5230/9047/files/BETOPPER_Stage_Led_Light_COB_Par_Light_LC001-H_User_Manual.pdf?v=1630045858"
"https://cdn.shopifycdn.net/s/files/1/0084/5230/9047/files/BETOPPER_Stage_Led_Light_COB_Par_Light_LC001-H_User_Manual.pdf"

"Warm White": {
"capability": {
"type": "ColorIntensity",
"color": "White"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"color": "White"
"color": "Warm White"

"Cold White": {
"capability": {
"type": "ColorIntensity",
"color": "White"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"color": "White"
"color": "Cold White"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging, copy and rename to "LC003-HB", see #4748 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants