Skip to content

Conversation

@fxedel
Copy link
Member

@fxedel fxedel commented Feb 27, 2017

No description provided.

@fxedel fxedel added the component-test Affects the automated tests. label Feb 27, 2017
@fxedel fxedel requested a review from FloEdelmann February 27, 2017 22:48
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-20 February 27, 2017 22:48 Inactive
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes are looking good but I just recognized we don't yet cover the case that an index file has a manufacturer that is not present in file system.

@fxedel
Copy link
Member Author

fxedel commented Feb 28, 2017

@FloEdelmann That's only right for manufacturers without fixtures – e. g., american-dj is mentioned in index (with no fixtures) and in manufacturer data (with nice name and website), but not in file system. I don't think that's wrong as there's no need for empty directories and deleting those manufacturers would mean data loss.

If the index mentions a manufacturer with fixtures that isn't present in file structure, it doesn't directly give an error but the fixtures do. (E. g., if we added 'super-lighting-device' in index to american-dj, the error Index mentions fixture 'super-lighting-device' of manufacturer 'american-dj' which is not present in file structure is given and the test fails.)

@FloEdelmann
Copy link
Member

You're right, I guess we already discussed this sometime.

@fxedel fxedel merged commit 6a959e7 into master Feb 28, 2017
@FloEdelmann FloEdelmann deleted the index-test branch February 28, 2017 11:47
@FloEdelmann FloEdelmann mentioned this pull request Sep 6, 2018
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component-test Affects the automated tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants