Add fixture fos/lifting-ball-dmx
#1302
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloEdelmann
added
new-fixture
Member
Author
Export files validity(Output of test script Test the exported files of selected fixtures against the plugins' export tests. ❌ fos / lifting-ball-dmx: d-light / attributes-correctness
❌ fos / lifting-ball-dmx: millumin / json-schema-conformity
✔️ fos / lifting-ball-dmx: qlcplus_4.12.2 / fixture-tool-validation
❌ fos / lifting-ball-dmx: qlcplus_4.12.2 / xsd-schema-conformity
|
FloEdelmann
changed the title
fos/lifting-ball-dmx
kengruven
reviewed
Dec 17, 2024
| "comment": "created by Q Light Controller Plus (version 4.12.2)" | ||
| } | ||
| }, | ||
| "physical": { |
Contributor
There was a problem hiding this comment.
Suggested change
| "physical": { | |
| "links": { | |
| "manual": [ | |
| "https://www.fos-lighting.eu/uploads/products_1_2_1_42.pdf" | |
| ] | |
| }, | |
| "physical": { |
Comment on lines
+24
to
+30
| "matrix": { | ||
| "pixelCount": [ | ||
| null, | ||
| null, | ||
| 1 | ||
| ] | ||
| }, |
Contributor
There was a problem hiding this comment.
Suggested change
| "matrix": { | |
| "pixelCount": [ | |
| null, | |
| null, | |
| 1 | |
| ] | |
| }, |
| }, | ||
| { | ||
| "dmxRange": [253, 255], | ||
| "type": "Maintenance" |
Contributor
There was a problem hiding this comment.
Suggested change
| "type": "Maintenance" | |
| "type": "Maintenance", | |
| "comment": "Reset" |
Comment on lines
+124
to
+125
| "type": "ColorPreset", | ||
| "comment": "Off" |
Contributor
There was a problem hiding this comment.
Suggested change
| "type": "ColorPreset", | |
| "comment": "Off" | |
| "type": "NoFunction" |
| }, | ||
| { | ||
| "dmxRange": [8, 231], | ||
| "type": "ColorPreset", |
Contributor
There was a problem hiding this comment.
Suggested change
| "type": "ColorPreset", | |
| "type": "Effect", | |
| "effectPreset": "ColorFade", |
| }, | ||
| { | ||
| "dmxRange": [232, 255], | ||
| "type": "ColorPreset", |
Contributor
There was a problem hiding this comment.
Suggested change
| "type": "ColorPreset", | |
| "type": "Effect", | |
| "effectPreset": "ColorFade", | |
| "speedStart": "slow", | |
| "speedEnd": "fast", |
| ] | ||
| } | ||
| }, | ||
| "templateChannels": {}, |
Contributor
There was a problem hiding this comment.
Suggested change
| "templateChannels": {}, |
Comment on lines
+38
to
+39
| "angleEnd": "100%", | ||
| "helpWanted": "Can you provide exact angles?" |
Contributor
There was a problem hiding this comment.
Suggested change
| "angleEnd": "100%", | |
| "helpWanted": "Can you provide exact angles?" | |
| "angleEnd": "100%" |
This is a winch, so it's not angles. Is "Tilt" the correct type to use for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixture warnings / errors
Thank you Frank!