Skip to content

Conversation

@FloEdelmann
Copy link
Member

  • Add fixture 'laserworld/shownet'

Fixture warnings / errors

  • laserworld/shownet
    • ❌ File does not match schema. [
      {
      keyword: 'minimum',
      dataPath: '.matrix.pixelCount[0]',
      schemaPath: '#/properties/matrix/properties/pixelCount/items/minimum',
      params: { comparison: '>=', limit: 1, exclusive: false },
      message: 'should be >= 1'
      },
      [length]: 1
      ]
    • ⚠️ Please check if manufacturer is correct.
    • ⚠️ Please check 16bit channel 'Position X fine': The corresponding coarse channel could not be detected.
    • ⚠️ Please add prof mode's Head initial structure #1 to the fixture's matrix. The included channels were Positios x, Position y.

User comment

Laserworl ShowNet 2017 Fixture

Thank you @elixxx!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Jan 15, 2020
@FloEdelmann FloEdelmann temporarily deployed to ofl-branch2020-01-15t08-xjaljb January 15, 2020 08:09 Inactive
@FloEdelmann
Copy link
Member Author

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ laserworld / shownet: d-light / attributes-correctness
  • ✔️ laserworld/shownet-DJ.xml
  • ✔️ laserworld/shownet-Professional.xml
✔️ laserworld / shownet: millumin / json-schema-conformity
  • ✔️ laserworld/shownet.json
laserworld / shownet: qlcplus_4.12.1 / fixture-tool-validation
  • ❌ fixtures/Laserworld-ShowNET.qxfNamespace(convert=None, map=False, validate=['.']) manufacturer/fixture.qxf: Invalid physical dimensions detected manufacturer/fixture.qxf: Invalid PAN degrees manufacturer/fixture.qxf: Invalid TILT degrees manufacturer/fixture.qxf: Invalid power consumption 1 definitions processed. 4 errors detected
laserworld / shownet: qlcplus_4.12.1 / xsd-schema-conformity
  • ❌ fixtures/Laserworld-ShowNET.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': '0' is not a valid value of the atomic type '{http://www.qlcplus.org/FixtureDefinition}weightType'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.

Copy link
Member

@fxedel fxedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FloEdelmann Please review as well

Copy link
Member Author

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ LGTM

@FloEdelmann FloEdelmann merged commit 7043769 into master Feb 16, 2020
@FloEdelmann FloEdelmann deleted the branch2020-01-15T08-09-35 branch February 16, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants