Skip to content

Add meaningful tests #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fxedel merged 25 commits into from
Feb 27, 2017
Merged

Add meaningful tests #11

fxedel merged 25 commits into from
Feb 27, 2017

Conversation

@fxedel
Copy link
Member

@fxedel fxedel commented Feb 25, 2017 •
edited by FloEdelmann
Loading

closes #3

@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-11 February 25, 2017 23:13 Inactive
@fxedel fxedel added the component-test Affects the automated tests. label Feb 25, 2017
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-11 February 25, 2017 23:33 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-11 February 25, 2017 23:38 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-11 February 25, 2017 23:44 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-11 February 26, 2017 00:00 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-11 February 26, 2017 00:03 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-11 February 26, 2017 00:18 Inactive
fxedel
fxedel commented Feb 26, 2017
View reviewed changes
tests/manufacturers_index_correct.js Outdated
}

if (!failed) {
console.log(colors.green('Test passed.'));
Copy link
Member Author

@fxedel fxedel Feb 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More details in this message wished.

Copy link
Member Author

@fxedel fxedel Feb 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

fxedel
fxedel commented Feb 26, 2017
View reviewed changes
tests/manufacturers_index_correct.js Outdated

// get index (and adjust the fixtures' names)
const fixturePath = path.join(__dirname, '..', 'fixtures');
const index = JSON.parse(fs.readFileSync(path.join(fixturePath, 'index_manufacturers.json'), 'utf8'));
Copy link
Member Author

@fxedel fxedel Feb 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add console message printing the used index filename.

Copy link
Member Author

@fxedel fxedel Feb 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-11 February 26, 2017 08:48 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-11 February 26, 2017 08:51 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-11 February 26, 2017 16:09 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-11 February 26, 2017 16:44 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-11 February 26, 2017 16:53 Inactive
@fxedel
Copy link
Member Author

fxedel commented Feb 26, 2017 •
edited by FloEdelmann
Loading

Needs to be done before merging:

  • add test for manufacturers.json
  • add test for index_types.json
  • finish channel testing in fixtures_valid.js test
  • final review of all tests

@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-11 February 27, 2017 17:29 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-11 February 27, 2017 17:55 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-11 February 27, 2017 17:56 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-11 February 27, 2017 19:14 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-11 February 27, 2017 19:57 Inactive
FloEdelmann
FloEdelmann approved these changes Feb 27, 2017
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fxedel fxedel merged this pull request into master Feb 27, 2017
fxedel added a commit that referenced this pull request Feb 27, 2017
@fxedel
Add meaningful tests (#11), closes #3
b66a2dd
@fxedel fxedel changed the title WIP: Add meaningful tests Add meaningful tests Feb 27, 2017
@fxedel fxedel deleted the add-meaningful-tests branch February 27, 2017 20:54
@FloEdelmann FloEdelmann mentioned this pull request Sep 6, 2018
Merged
11 tasks
@FloEdelmann FloEdelmann mentioned this pull request Nov 24, 2022
Closed
@FloEdelmann FloEdelmann mentioned this pull request May 5, 2024
Draft
@FloEdelmann FloEdelmann mentioned this pull request Jan 15, 2025
Draft
This was referenced Jan 24, 2025
Draft
Draft
This was referenced May 20, 2025
Closed
Closed
@FloEdelmann FloEdelmann mentioned this pull request Aug 23, 2025
Closed
This was referenced Dec 6, 2025
Draft
Draft
@FloEdelmann FloEdelmann mentioned this pull request Dec 18, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees

No one assigned

Labels

component-test Affects the automated tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add meaningful tests

3 participants

@fxedel @FloEdelmann