Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-Commit Hook - Milestone 1 (FOSS Overflow 2024) #107

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Pre-Commit Hook - Milestone 1 (FOSS Overflow 2024) #107

wants to merge 3 commits into from
+6,742 −5,529

Conversation

jaiakash
Copy link
Contributor

@jaiakash jaiakash commented Jan 21, 2024 •
edited
Loading

Purpose ✨

For better quality and consistency, this PR add pre-commit hooks for using eslint and prettier. Fixes #102

Details 📝

  • Added eslint rules and prettier rules for react frontend.
  • For backend, I am thinking to do after completing milestone 2 (refractoring the frontend code.)

Dependencies 🔗

eslint, husky and prettier

Future Improvements 🔭

TODO - Implement pre-commit hook for backend as well.

Developer's checklist 📃

  • Followed the coding guidelines.
  • Properly commented the code.
  • All the functionalities are working properly.
  • Changes made are not breaking any other part of the project.
  • Followed the PR guidelines

@jaiakash jaiakash marked this pull request as ready for review January 25, 2024 08:16
@jaiakash jaiakash marked this pull request as draft January 26, 2024 22:17
@jaiakash jaiakash changed the title Pre-Commit Hook Pre-Commit Hook - Milestone 1 (FOSS Overflow 2024) Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Pre-commit Hooks for Code Quality
1 participant
@jaiakash