Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix for mon_control #3401

Merged
merged 1 commit into from
Apr 16, 2021
Merged

bug fix for mon_control #3401

merged 1 commit into from
Apr 16, 2021

Conversation

ya4ept
Copy link
Contributor

@ya4ept ya4ept commented Apr 16, 2021

In the packages "actor_display" and "actor_info" there is a space in the name of the monster at the end of the word.
изображение
This is typical for Russian monsters.
Because of this openkore stores the monster name as "Дикая кошка " instead of "Дикая кошка" (Wild Rose)
Thus, if you write the name of the monster instead of its ID in the mon_control.txt file, then these settings do not work.
Also, NPC names contain a space in the name.

Now in the file mon_control.txt you can specify Russian names of monsters. This error could be with other non-English languages.

PS: i don't understand this code

# New actor_display packets include the player's name
if ($args->{switch} eq "0086") {
	$actor->{name} = $args->{name};
} else {
	$actor->{name} = bytesToString($args->{name}) if exists $args->{name};
}

"0086" package does not contain the actor name:
'0086' => ['actor_display', 'a4 a6 V', [qw(ID coords tick)]],
I am sure that we can easily shorten this code:
изображение

Now in the file mon_control.txt you can specify Russian names of monsters. This error could be with other non-English languages.
@alisonrag
Copy link
Contributor

alisonrag commented Apr 16, 2021

this also fixes #3361
well done

@ya4ept ya4ept merged commit 091bcef into master Apr 16, 2021
@ya4ept ya4ept deleted the fix_mon_control branch April 16, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants