Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Apr 21, 2011

The functions added are related to the following registers:

  • Chip Version (R0:0 / 0x0000)
  • Row Start (R1:0 / 0x0001)
  • Column Start (R2:0 / 0x0002)
  • Row Count (R3:0 / 0x0003)
  • Column Count (R4:0 / 0x0004)
  • Aperture Correction (R5:1 / 0x0105)
  • Color Saturation Control (R37:1 / 0x0125)

The Row/Column Start/Count functions were folded into a pair of functions (freenect_get_cmos_window_setting(), and s/get/set for the 'setter' version) to make it easier (used to be 8 separate API functions..).

The functionality for the above API functions are found inside cmos.c.

The pull request also includes some earlier work, horizontal flip toggling, found inside cameras.c.

  • Team "When It's Done" (via sslemon)

Signed-off-by: James D Goodrich Jr <jdgoodrichjr@gmail.com> (sslemon)
@zarvox
Copy link
Member

zarvox commented Apr 21, 2011

Thanks for all the work you've put into this functionality! I've got a blocker that I'll need you to rework...

It appears that you're still working against the old API, which possibly explains why the diffstat has a rewrite of libfreenect.h, rather than simply additions as I expected. If you take a look at git unstable, you should see the new API (notably, the removal of #defines like FREENECT_FRAME_PIX and moving instead to freenect_get_video_frame_mode() and the like). Merging this commit straight-up would mean reverting to the old API, which I don't think I want to do.

If you can, please rebase your changes against git unstable, merge the two (preferring the new API where applicable), and resubmit. If you push --force to github and clobber the old commit, I believe github will actually just update this pull request, so for convenience, you don't have to close/reopen this pull request.

If you need more guidance on how to cleanly merge your work, hit me up on IRC.

I'll add line-item comments where I see other things that I might want revisited.

@piedar piedar modified the milestones: v0.4.1, v0.4.0 Feb 3, 2014
@piedar piedar modified the milestones: v0.5.0, v0.4.1 Feb 16, 2014
@piedar piedar closed this Mar 22, 2014
@piedar
Copy link
Contributor

piedar commented Mar 31, 2014

This issue was closed by Github when I deleted the unstable branch. It should be considered Open.

@piedar piedar modified the milestones: v0.4.3, v0.5.0 Mar 31, 2014
@piedar piedar modified the milestones: v0.5.1, v0.4.3 May 11, 2014
@piedar piedar modified the milestones: v0.6.1, v0.5.1 Jul 15, 2014
@piedar piedar modified the milestones: v0.6.1, v1.0.0 Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants